2020-07-02 15:09:13

by Alessio Bonfiglio

[permalink] [raw]
Subject: [PATCH] iwlwifi: Make some Killer Wireless-AC 1550 cards working again

Fix the regression introduced by commit c8685937d07f ("iwlwifi: move pu devices to new table") by add the ids and the configurations of two missing Killer 1550 cards in order to make these cards being configured and working correctly again (following the new table convention).
Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2", https://bugzilla.kernel.org/show_bug.cgi?id=208141).

Fixes: c8685937d07f ("iwlwifi: move pu devices to new table")
Signed-off-by: Alessio Bonfiglio <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 65d65c6baf4c..e02bafb8921f 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -582,6 +582,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
IWL_DEV_INFO(0x30DC, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),
IWL_DEV_INFO(0x31DC, 0x1551, iwl9560_2ac_cfg_soc, iwl9560_killer_1550s_name),
IWL_DEV_INFO(0x31DC, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),
+ IWL_DEV_INFO(0xA370, 0x1551, iwl9560_2ac_cfg_soc, iwl9560_killer_1550s_name),
+ IWL_DEV_INFO(0xA370, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),

IWL_DEV_INFO(0x271C, 0x0214, iwl9260_2ac_cfg, iwl9260_1_name),

--
2.27.0


2020-07-14 08:53:42

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: Make some Killer Wireless-AC 1550 cards working again

Alessio Bonfiglio <[email protected]> writes:

> Fix the regression introduced by commit c8685937d07f ("iwlwifi: move pu devices to new table") by add the ids and the configurations of two missing Killer 1550 cards in order to make these cards being configured and working correctly again (following the new table convention).
> Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2", https://bugzilla.kernel.org/show_bug.cgi?id=208141).

Max 72 chars per line, please word wrap your commit log.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-07-14 09:23:47

by Alessio Bonfiglio

[permalink] [raw]
Subject: [PATCH v2] iwlwifi: Make some Killer Wireless-AC 1550 cards work again

Fix the regression introduced by commit c8685937d07f ("iwlwifi: move
pu devices to new table") by adding the ids and the configurations of
two missing Killer 1550 cards in order to configure and let them work
correctly again (following the new table convention).
Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2",
https://bugzilla.kernel.org/show_bug.cgi?id=208141).

Fixes: c8685937d07f ("iwlwifi: move pu devices to new table")
Signed-off-by: Alessio Bonfiglio <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 65d65c6baf4c..e02bafb8921f 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -582,6 +582,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
IWL_DEV_INFO(0x30DC, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),
IWL_DEV_INFO(0x31DC, 0x1551, iwl9560_2ac_cfg_soc, iwl9560_killer_1550s_name),
IWL_DEV_INFO(0x31DC, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),
+ IWL_DEV_INFO(0xA370, 0x1551, iwl9560_2ac_cfg_soc, iwl9560_killer_1550s_name),
+ IWL_DEV_INFO(0xA370, 0x1552, iwl9560_2ac_cfg_soc, iwl9560_killer_1550i_name),

IWL_DEV_INFO(0x271C, 0x0214, iwl9260_2ac_cfg, iwl9260_1_name),

--
2.27.0

2020-07-14 09:54:40

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] iwlwifi: Make some Killer Wireless-AC 1550 cards work again

Alessio Bonfiglio <[email protected]> writes:

> Fix the regression introduced by commit c8685937d07f ("iwlwifi: move
> pu devices to new table") by adding the ids and the configurations of
> two missing Killer 1550 cards in order to configure and let them work
> correctly again (following the new table convention).
> Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2",
> https://bugzilla.kernel.org/show_bug.cgi?id=208141).
>
> Fixes: c8685937d07f ("iwlwifi: move pu devices to new table")
> Signed-off-by: Alessio Bonfiglio <[email protected]>

Luca, should I take this to v5.8?

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-07-14 11:27:30

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: [PATCH v2] iwlwifi: Make some Killer Wireless-AC 1550 cards work again

> Alessio Bonfiglio <[email protected]> writes:
>
> > Fix the regression introduced by commit c8685937d07f ("iwlwifi: move
> > pu devices to new table") by adding the ids and the configurations of
> > two missing Killer 1550 cards in order to configure and let them work
> > correctly again (following the new table convention).
> > Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2",
> > https://bugzilla.kernel.org/show_bug.cgi?id=208141).
> >
> > Fixes: c8685937d07f ("iwlwifi: move pu devices to new table")
> > Signed-off-by: Alessio Bonfiglio <[email protected]>
>
> Luca, should I take this to v5.8?

Luca is OOO, but I guess you should, yes.

Thanks.

2020-07-20 16:43:02

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] iwlwifi: Make some Killer Wireless-AC 1550 cards work again

Alessio Bonfiglio <[email protected]> wrote:

> Fix the regression introduced by commit c8685937d07f ("iwlwifi: move
> pu devices to new table") by adding the ids and the configurations of
> two missing Killer 1550 cards in order to configure and let them work
> correctly again (following the new table convention).
> Resolve bug 208141 ("Wireless ac 9560 not working kernel 5.7.2",
> https://bugzilla.kernel.org/show_bug.cgi?id=208141).
>
> Fixes: c8685937d07f ("iwlwifi: move pu devices to new table")
> Signed-off-by: Alessio Bonfiglio <[email protected]>

Patch applied to wireless-drivers.git, thanks.

b5ba46b81c2f iwlwifi: Make some Killer Wireless-AC 1550 cards work again

--
https://patchwork.kernel.org/patch/11662083/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches