2023-10-03 05:22:11

by Eric Dumazet

[permalink] [raw]
Subject: Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule

On Mon, Oct 2, 2023 at 5:10 PM Christian Marangi <[email protected]> wrote:
>
> Change napi_schedule to return a bool on NAPI successful schedule. This
> might be useful for some driver to do additional step after a NAPI ahs

This might be useful for some drivers to do additional steps after a
NAPI has been scheduled.

> been scheduled.
>
> Signed-off-by: Christian Marangi <[email protected]>

Yeah, I guess you forgot to mention I suggested this patch ...

Reviewed-by: Eric Dumazet <[email protected]>


2023-10-03 10:26:13

by Christian Marangi

[permalink] [raw]
Subject: Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule

On Tue, Oct 03, 2023 at 07:21:46AM +0200, Eric Dumazet wrote:
> On Mon, Oct 2, 2023 at 5:10 PM Christian Marangi <[email protected]> wrote:
> >
> > Change napi_schedule to return a bool on NAPI successful schedule. This
> > might be useful for some driver to do additional step after a NAPI ahs
>
> This might be useful for some drivers to do additional steps after a
> NAPI has been scheduled.
>
> > been scheduled.
> >
> > Signed-off-by: Christian Marangi <[email protected]>
>
> Yeah, I guess you forgot to mention I suggested this patch ...
>
> Reviewed-by: Eric Dumazet <[email protected]>

Yes sorry, totally forgot to add this here. I already have the patch for the
other driver (but it's dependant on this so I'm waiting) and I forgot to
add the tag also for this piece.

--
Ansuel