2011-07-06 11:05:09

by Carsten Rietzschel

[permalink] [raw]
Subject: RALINK rt2800pci , Patch for Device [1814:539f]

Hello together,

attached find a small patch for the RALINK wireless driver.
It's just adding one PCI-ID for:

02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
Subsystem: Hewlett-Packard Company Device [103c:1637]
Flags: bus master, fast devsel, latency 0, IRQ 17
Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
Capabilities: [40] Power Management version 3
Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
Capabilities: [70] Express Endpoint, MSI 00
Capabilities: [100] Advanced Error Reporting
Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
Kernel driver in use: rt2800pci
Kernel modules: rt2800pci

It's for instance used in the HP DM1Z (Fusion) Netbook.
I use this patch now for several weeks - starting with 2.3.29 up to
3.0-rc2 kernel. No problems so far.

*Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>
---
diff -ur linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c
linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
--- linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c
2011-07-06 12:46:13.251676122 +0200
+++ linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
2011-07-06 12:44:38.381673254 +0200
@@ -1158,6 +1158,7 @@
#endif
#ifdef CONFIG_RT2800PCI_RT53XX
{ PCI_DEVICE(0x1814, 0x5390) },
+ { PCI_DEVICE(0x1814, 0x539f) },
#endif
{ 0, }
};


Feel free to include it or do what you want ;-)
If you need any further information - please just let me know.

Best regards.
Carsten


2011-07-06 11:15:57

by Julian Calaby

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

On Wed, Jul 6, 2011 at 21:02, Helmut Schaa <[email protected]> wrote:
> Nice.
>
> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
>> Hello together,
>>
>> attached find a small patch for the RALINK wireless driver.
>> It's just adding one PCI-ID for:
>>
>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>> ? ?Subsystem: Hewlett-Packard Company Device [103c:1637]
>> ? ?Flags: bus master, fast devsel, latency 0, IRQ 17
>> ? ?Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>> ? ?Capabilities: [40] Power Management version 3
>> ? ?Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>> ? ?Capabilities: [70] Express Endpoint, MSI 00
>> ? ?Capabilities: [100] Advanced Error Reporting
>> ? ?Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>> ? ?Kernel driver in use: rt2800pci
>> ? ?Kernel modules: rt2800pci
>>
>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>> I use this patch now for several weeks - starting with 2.3.29 up to
>> 3.0-rc2 kernel. No problems so far.
>>
>> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>
>
> That should be "Signed-off-by:". Mind to resubmit?

And, IIRC, you shouldn't censor your email address.

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

2011-07-06 12:31:25

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

Hi,

On Wed, Jul 6, 2011 at 1:15 PM, Gertjan van Wingerde
<[email protected]> wrote:
> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
>> Hello together,
>>
>> attached find a small patch for the RALINK wireless driver.
>> It's just adding one PCI-ID for:
>>
>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>> ? ?Subsystem: Hewlett-Packard Company Device [103c:1637]
>> ? ?Flags: bus master, fast devsel, latency 0, IRQ 17
>> ? ?Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>> ? ?Capabilities: [40] Power Management version 3
>> ? ?Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>> ? ?Capabilities: [70] Express Endpoint, MSI 00
>> ? ?Capabilities: [100] Advanced Error Reporting
>> ? ?Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>> ? ?Kernel driver in use: rt2800pci
>> ? ?Kernel modules: rt2800pci
>>
>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>> I use this patch now for several weeks - starting with 2.3.29 up to
>> 3.0-rc2 kernel. No problems so far.
>>
>> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>
>
> This device ID has already been added in the latest rt2x00.git tree via patch:
> http://git.kernel.org/?p=linux/kernel/git/ivd/rt2x00.git;a=commit;h=c56a574019a75c1ca36c540a8ab092a7ed35020d
>
> However, this hasn't been propagated to the wireless tree yet.
>
> Ivo, when are you planning to submit all pending patches towards the
> wireless tree?

Well actually I planned that for last weekend... :)
I'll go for the retry this evening.

Ivo

2011-07-06 11:22:45

by Carsten Rietzschel

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

Thanks,

here we go with a changed Signed-off-by-Line.
In case it's usefull even it's already in the git-tree.

Signed-off-by: Carsten Rietzschel <[email protected]>

diff -ur linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c
linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
--- linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c 2011-07-06
12:46:13.251676122 +0200
+++ linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
2011-07-06 12:44:38.381673254 +0200
@@ -1158,6 +1158,7 @@
#endif
#ifdef CONFIG_RT2800PCI_RT53XX
{ PCI_DEVICE(0x1814, 0x5390) },
+ { PCI_DEVICE(0x1814, 0x539f) },
#endif
{ 0, }
};

cya.
Carsten

Am 06.07.2011 13:02, schrieb Helmut Schaa:
> Nice.
>
> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
>> Hello together,
>>
>> attached find a small patch for the RALINK wireless driver.
>> It's just adding one PCI-ID for:
>>
>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>> Subsystem: Hewlett-Packard Company Device [103c:1637]
>> Flags: bus master, fast devsel, latency 0, IRQ 17
>> Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>> Capabilities: [40] Power Management version 3
>> Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>> Capabilities: [70] Express Endpoint, MSI 00
>> Capabilities: [100] Advanced Error Reporting
>> Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>> Kernel driver in use: rt2800pci
>> Kernel modules: rt2800pci
>>
>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>> I use this patch now for several weeks - starting with 2.3.29 up to
>> 3.0-rc2 kernel. No problems so far.
>>
>> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>
> That should be "Signed-off-by:". Mind to resubmit?
>
> Otherwise no objections from my side :)
> Helmut


Am 06.07.2011 13:15, schrieb Julian Calaby:
> On Wed, Jul 6, 2011 at 21:02, Helmut Schaa <[email protected]> wrote:
>> Nice.
>>
>> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
>>> Hello together,
>>>
>>> attached find a small patch for the RALINK wireless driver.
>>> It's just adding one PCI-ID for:
>>>
>>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>>> Subsystem: Hewlett-Packard Company Device [103c:1637]
>>> Flags: bus master, fast devsel, latency 0, IRQ 17
>>> Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>>> Capabilities: [40] Power Management version 3
>>> Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>>> Capabilities: [70] Express Endpoint, MSI 00
>>> Capabilities: [100] Advanced Error Reporting
>>> Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>>> Kernel driver in use: rt2800pci
>>> Kernel modules: rt2800pci
>>>
>>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>>> I use this patch now for several weeks - starting with 2.3.29 up to
>>> 3.0-rc2 kernel. No problems so far.
>>>
>>> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>
>> That should be "Signed-off-by:". Mind to resubmit?
> And, IIRC, you shouldn't censor your email address.
>
> Thanks,
>


2011-07-06 11:15:22

by Gertjan van Wingerde

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
> Hello together,
>
> attached find a small patch for the RALINK wireless driver.
> It's just adding one PCI-ID for:
>
> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
> ? ?Subsystem: Hewlett-Packard Company Device [103c:1637]
> ? ?Flags: bus master, fast devsel, latency 0, IRQ 17
> ? ?Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
> ? ?Capabilities: [40] Power Management version 3
> ? ?Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
> ? ?Capabilities: [70] Express Endpoint, MSI 00
> ? ?Capabilities: [100] Advanced Error Reporting
> ? ?Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
> ? ?Kernel driver in use: rt2800pci
> ? ?Kernel modules: rt2800pci
>
> It's for instance used in the HP DM1Z (Fusion) Netbook.
> I use this patch now for several weeks - starting with 2.3.29 up to
> 3.0-rc2 kernel. No problems so far.
>
> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>

This device ID has already been added in the latest rt2x00.git tree via patch:
http://git.kernel.org/?p=linux/kernel/git/ivd/rt2x00.git;a=commit;h=c56a574019a75c1ca36c540a8ab092a7ed35020d

However, this hasn't been propagated to the wireless tree yet.

Ivo, when are you planning to submit all pending patches towards the
wireless tree?

---
Gertjan.

2011-07-06 12:31:03

by Larry Finger

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

On 07/06/2011 06:22 AM, Carsten Rietzschel wrote:
> Thanks,
>
> here we go with a changed Signed-off-by-Line.
> In case it's usefull even it's already in the git-tree.
>
> Signed-off-by: Carsten Rietzschel<[email protected]>

There is bit more to proper patch submission. The subject of the Email should be
"[PATCH] rt2800pci: Add device ID [1814:539f]".

Inside the patch, the Signed-off-by line should be followed by a line with 3
dashes. Anything above those 3 dashes will be in the commit message for the
patch. The stuff shown above is not appropriate. That kind of message can be
added after the 3 dashes as instructions to the maintainer, etc. If you do that,
then another line of 3 dashes goes after that.

I don't think it causes any problems, but I usually get rid of any quoted
material after the patch.

To learn the whole business of patching, see the file at
Documentation/SubmittingPatches in any source tree.

Larry

>
> diff -ur linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c
> linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
> --- linux-3.0_rc2/drivers/net/wireless/rt2x00/rt2800pci.c 2011-07-06
> 12:46:13.251676122 +0200
> +++ linux-3.0_rc2_patched/drivers/net/wireless/rt2x00/rt2800pci.c
> 2011-07-06 12:44:38.381673254 +0200
> @@ -1158,6 +1158,7 @@
> #endif
> #ifdef CONFIG_RT2800PCI_RT53XX
> { PCI_DEVICE(0x1814, 0x5390) },
> + { PCI_DEVICE(0x1814, 0x539f) },
> #endif
> { 0, }
> };
>
> cya.
> Carsten
>
> Am 06.07.2011 13:02, schrieb Helmut Schaa:
>> Nice.
>>
>> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel<[email protected]> wrote:
>>> Hello together,
>>>
>>> attached find a small patch for the RALINK wireless driver.
>>> It's just adding one PCI-ID for:
>>>
>>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>>> Subsystem: Hewlett-Packard Company Device [103c:1637]
>>> Flags: bus master, fast devsel, latency 0, IRQ 17
>>> Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>>> Capabilities: [40] Power Management version 3
>>> Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>>> Capabilities: [70] Express Endpoint, MSI 00
>>> Capabilities: [100] Advanced Error Reporting
>>> Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>>> Kernel driver in use: rt2800pci
>>> Kernel modules: rt2800pci
>>>
>>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>>> I use this patch now for several weeks - starting with 2.3.29 up to
>>> 3.0-rc2 kernel. No problems so far.
>>>
>>> *Signed*-*off*-by: Carsten Rietzschel<cr7 [at] darav [dot] de>
>> That should be "Signed-off-by:". Mind to resubmit?
>>
>> Otherwise no objections from my side :)
>> Helmut
>
>
> Am 06.07.2011 13:15, schrieb Julian Calaby:
>> On Wed, Jul 6, 2011 at 21:02, Helmut Schaa<[email protected]> wrote:
>>> Nice.
>>>
>>> On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel<[email protected]> wrote:
>>>> Hello together,
>>>>
>>>> attached find a small patch for the RALINK wireless driver.
>>>> It's just adding one PCI-ID for:
>>>>
>>>> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
>>>> Subsystem: Hewlett-Packard Company Device [103c:1637]
>>>> Flags: bus master, fast devsel, latency 0, IRQ 17
>>>> Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
>>>> Capabilities: [40] Power Management version 3
>>>> Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
>>>> Capabilities: [70] Express Endpoint, MSI 00
>>>> Capabilities: [100] Advanced Error Reporting
>>>> Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
>>>> Kernel driver in use: rt2800pci
>>>> Kernel modules: rt2800pci
>>>>
>>>> It's for instance used in the HP DM1Z (Fusion) Netbook.
>>>> I use this patch now for several weeks - starting with 2.3.29 up to
>>>> 3.0-rc2 kernel. No problems so far.
>>>>
>>>> *Signed*-*off*-by: Carsten Rietzschel<cr7 [at] darav [dot] de>
>>> That should be "Signed-off-by:". Mind to resubmit?
>> And, IIRC, you shouldn't censor your email address.
>>
>> Thanks,
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


2011-07-06 11:02:36

by Helmut Schaa

[permalink] [raw]
Subject: Re: RALINK rt2800pci , Patch for Device [1814:539f]

Nice.

On Wed, Jul 6, 2011 at 12:58 PM, Carsten Rietzschel <[email protected]> wrote:
> Hello together,
>
> attached find a small patch for the RALINK wireless driver.
> It's just adding one PCI-ID for:
>
> 02:00.0 Network controller [0280]: Ralink corp. Device [1814:539f]
> ? ?Subsystem: Hewlett-Packard Company Device [103c:1637]
> ? ?Flags: bus master, fast devsel, latency 0, IRQ 17
> ? ?Memory at f0100000 (32-bit, non-prefetchable) [size=64K]
> ? ?Capabilities: [40] Power Management version 3
> ? ?Capabilities: [50] MSI: Enable- Count=1/32 Maskable- 64bit+
> ? ?Capabilities: [70] Express Endpoint, MSI 00
> ? ?Capabilities: [100] Advanced Error Reporting
> ? ?Capabilities: [140] Device Serial Number 00-00-b2-7f-05-da-f8-c0
> ? ?Kernel driver in use: rt2800pci
> ? ?Kernel modules: rt2800pci
>
> It's for instance used in the HP DM1Z (Fusion) Netbook.
> I use this patch now for several weeks - starting with 2.3.29 up to
> 3.0-rc2 kernel. No problems so far.
>
> *Signed*-*off*-by: Carsten Rietzschel <cr7 [at] darav [dot] de>

That should be "Signed-off-by:". Mind to resubmit?

Otherwise no objections from my side :)
Helmut