2012-12-02 16:24:06

by Gabor Juhos

Subject: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines

Signed-off-by: Gabor Juhos <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
index 6d67c3e..1157b06 100644
--- a/drivers/net/wireless/rt2x00/rt2800.h
+++ b/drivers/net/wireless/rt2x00/rt2800.h
@@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
*/
#define RFCSR3_K FIELD8(0x0f)
/* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
-#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
-#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
+#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
+#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)

/*
* FRCSR 5:
--
1.7.10

2012-12-02 16:26:37

by Ivo Van Doorn

Subject: Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines

On Sun, Dec 2, 2012 at 5:24 PM, Gabor Juhos <[email protected]> wrote:
> Signed-off-by: Gabor Juhos <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-12-02 22:39:24

by Gertjan van Wingerde

Subject: Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines

Sent from my iPad

On 2 dec. 2012, at 16:24, Gabor Juhos <[email protected]> wrote:

> Signed-off-by: Gabor Juhos <[email protected]>

Ouch, that could have led to some nasty bugs. Thanks for spotting this and sending the patch.

Acked-by: Gertjan van Wingerde <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html