2011-12-14 15:28:52

by Helmut Schaa

Subject: [PATCH] rt2x00: Make use of ieee80211_free_txskb in tx path

ieee80211_free_txskb should be used when dropping a frame in the device
rx path such that mac80211 knows about this frame being dropped.

Signed-off-by: Helmut Schaa <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00mac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
index 7996cd0..5889558 100644
--- a/drivers/net/wireless/rt2x00/rt2x00mac.c
+++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
@@ -159,7 +159,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
exit_fail:
rt2x00queue_pause_queue(queue);
exit_free_skb:
- dev_kfree_skb_any(skb);
+ ieee80211_free_txskb(hw, skb);
}
EXPORT_SYMBOL_GPL(rt2x00mac_tx);

--
1.7.7

2011-12-14 16:24:07

by Gertjan van Wingerde

Subject: Re: [PATCH] rt2x00: Make use of ieee80211_free_txskb in tx path

On Wed, Dec 14, 2011 at 4:28 PM, Helmut Schaa
<[email protected]> wrote:
> ieee80211_free_txskb should be used when dropping a frame in the device
> rx path such that mac80211 knows about this frame being dropped.
>
> Signed-off-by: Helmut Schaa <[email protected]>

Acked-by: Gertjan van Wingerde <[email protected]>

> ---
> ?drivers/net/wireless/rt2x00/rt2x00mac.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
> index 7996cd0..5889558 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
> @@ -159,7 +159,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> ?exit_fail:
> ? ? ? ?rt2x00queue_pause_queue(queue);
> ?exit_free_skb:
> - ? ? ? dev_kfree_skb_any(skb);
> + ? ? ? ieee80211_free_txskb(hw, skb);
> ?}
> ?EXPORT_SYMBOL_GPL(rt2x00mac_tx);
>
> --
> 1.7.7
>



--
---
Gertjan

2011-12-14 16:29:34

by Ivo Van Doorn

Subject: Re: [PATCH] rt2x00: Make use of ieee80211_free_txskb in tx path

On Wed, Dec 14, 2011 at 5:24 PM, Gertjan van Wingerde
<[email protected]> wrote:
> On Wed, Dec 14, 2011 at 4:28 PM, Helmut Schaa
> <[email protected]> wrote:
>> ieee80211_free_txskb should be used when dropping a frame in the device
>> rx path such that mac80211 knows about this frame being dropped.
>>
>> Signed-off-by: Helmut Schaa <[email protected]>
>
> Acked-by: Gertjan van Wingerde <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

>
>> ---
>> ?drivers/net/wireless/rt2x00/rt2x00mac.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
>> index 7996cd0..5889558 100644
>> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
>> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
>> @@ -159,7 +159,7 @@ void rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
>> ?exit_fail:
>> ? ? ? ?rt2x00queue_pause_queue(queue);
>> ?exit_free_skb:
>> - ? ? ? dev_kfree_skb_any(skb);
>> + ? ? ? ieee80211_free_txskb(hw, skb);
>> ?}
>> ?EXPORT_SYMBOL_GPL(rt2x00mac_tx);
>>
>> --
>> 1.7.7
>>
>
>
>
> --
> ---
> Gertjan