2012-02-08 13:26:10

by John Li

Subject: [PATCH] rt2x00:Add debug message for new chipset

From: John Li <[email protected]>

Signed-off-by: John Li <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 22a1a8f..6bdf6d6 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -3949,7 +3949,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
case RT5390:
break;
default:
- ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
+ ERROR(rt2x00dev, "Invalid RT chipset 0x%04x detected.\n", rt2x00dev->chip.rt);
return -ENODEV;
}

@@ -3968,7 +3968,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
case RF5390:
break;
default:
- ERROR(rt2x00dev, "Invalid RF chipset 0x%x detected.\n",
+ ERROR(rt2x00dev, "Invalid RF chipset 0x%04x detected.\n",
rt2x00dev->chip.rf);
return -ENODEV;
}
--
1.7.6.5

2012-02-08 22:03:04

by Gertjan van Wingerde

Subject: Re: [PATCH] rt2x00:Add debug message for new chipset

On 02/08/12 14:25, John Li wrote:
> From: John Li <[email protected]>
>
> Signed-off-by: John Li <[email protected]>

Acked-by: Gertjan van Wingerde <[email protected]>

> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 22a1a8f..6bdf6d6 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -3949,7 +3949,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> case RT5390:
> break;
> default:
> - ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> + ERROR(rt2x00dev, "Invalid RT chipset 0x%04x detected.\n", rt2x00dev->chip.rt);
> return -ENODEV;
> }
>
> @@ -3968,7 +3968,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> case RF5390:
> break;
> default:
> - ERROR(rt2x00dev, "Invalid RF chipset 0x%x detected.\n",
> + ERROR(rt2x00dev, "Invalid RF chipset 0x%04x detected.\n",
> rt2x00dev->chip.rf);
> return -ENODEV;
> }


--
---
Gertjan

2012-02-08 13:40:14

by Helmut Schaa

Subject: Re: [PATCH] rt2x00:Add debug message for new chipset

On Wed, Feb 8, 2012 at 2:25 PM, John Li <[email protected]> wrote:
> From: John Li <[email protected]>
>
> Signed-off-by: John Li <[email protected]>

No objections from my side.

Acked-by: Helmut Schaa <[email protected]>

> ---
> ?drivers/net/wireless/rt2x00/rt2800lib.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 22a1a8f..6bdf6d6 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -3949,7 +3949,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> ? ? ? ?case RT5390:
> ? ? ? ? ? ? ? ?break;
> ? ? ? ?default:
> - ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> + ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RT chipset 0x%04x detected.\n", rt2x00dev->chip.rt);
> ? ? ? ? ? ? ? ?return -ENODEV;
> ? ? ? ?}
>
> @@ -3968,7 +3968,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> ? ? ? ?case RF5390:
> ? ? ? ? ? ? ? ?break;
> ? ? ? ?default:
> - ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RF chipset 0x%x detected.\n",
> + ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RF chipset 0x%04x detected.\n",
> ? ? ? ? ? ? ? ? ? ? ?rt2x00dev->chip.rf);
> ? ? ? ? ? ? ? ?return -ENODEV;
> ? ? ? ?}
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html

2012-02-12 15:30:30

by Ivo Van Doorn

Subject: Re: [PATCH] rt2x00:Add debug message for new chipset

On Wed, Feb 8, 2012 at 2:25 PM, John Li <[email protected]> wrote:
> From: John Li <[email protected]>
>
> Signed-off-by: John Li <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

> ---
> ?drivers/net/wireless/rt2x00/rt2800lib.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 22a1a8f..6bdf6d6 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -3949,7 +3949,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> ? ? ? ?case RT5390:
> ? ? ? ? ? ? ? ?break;
> ? ? ? ?default:
> - ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RT chipset detected.\n");
> + ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RT chipset 0x%04x detected.\n", rt2x00dev->chip.rt);
> ? ? ? ? ? ? ? ?return -ENODEV;
> ? ? ? ?}
>
> @@ -3968,7 +3968,7 @@ int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
> ? ? ? ?case RF5390:
> ? ? ? ? ? ? ? ?break;
> ? ? ? ?default:
> - ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RF chipset 0x%x detected.\n",
> + ? ? ? ? ? ? ? ERROR(rt2x00dev, "Invalid RF chipset 0x%04x detected.\n",
> ? ? ? ? ? ? ? ? ? ? ?rt2x00dev->chip.rf);
> ? ? ? ? ? ? ? ?return -ENODEV;
> ? ? ? ?}
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html