2012-05-14 07:57:11

by Holger Schurig

Subject: ath9k: write-only variable rx.rxotherant ?!?!?

I looks like sc->rx.rxotherant is an almost write-only variable: "grep
-r rxotherant *":

./ath9k/recv.c: sc->rx.rxotherant = 0;
./ath9k/recv.c: if (++sc->rx.rxotherant >= 3)
./ath9k/recv.c: sc->rx.rxotherant = 0;
./ath9k/ath9k.h: u8 rxotherant;


--
http://www.holgerschurig.de

2012-05-14 08:02:44

by Johannes Berg

Subject: Re: ath9k: write-only variable rx.rxotherant ?!?!?

On Mon, 2012-05-14 at 09:57 +0200, Holger Schurig wrote:
> I looks like sc->rx.rxotherant is an almost write-only variable: "grep
> -r rxotherant *":
>
> ./ath9k/recv.c: sc->rx.rxotherant = 0;
> ./ath9k/recv.c: if (++sc->rx.rxotherant >= 3)

that reads it too

johannes

2012-05-14 08:11:38

by Holger Schurig

Subject: Re: ath9k: write-only variable rx.rxotherant ?!?!?

Ups, I oversaw the ++. I thought only zeros would ever be written there.

/me hides behind a tree