2013-12-20 02:22:53

by Wei Yongjun

Subject: [PATCH -next] ath9k: fix sparse non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warning:

drivers/net/wireless/ath/ath9k/spectral.c:500:24: warning:
symbol 'rfs_spec_scan_cb' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/ath/ath9k/spectral.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/spectral.c b/drivers/net/wireless/ath/ath9k/spectral.c
index 11adb5e..99f4de9 100644
--- a/drivers/net/wireless/ath/ath9k/spectral.c
+++ b/drivers/net/wireless/ath/ath9k/spectral.c
@@ -497,7 +497,7 @@ static int remove_buf_file_handler(struct dentry *dentry)
return 0;
}

-struct rchan_callbacks rfs_spec_scan_cb = {
+static struct rchan_callbacks rfs_spec_scan_cb = {
.create_buf_file = create_buf_file_handler,
.remove_buf_file = remove_buf_file_handler,
};

2013-12-20 03:18:55

by Sujith Manoharan

Subject: Re: [PATCH -next] ath9k: fix sparse non static symbol warning

Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warning:
>
> drivers/net/wireless/ath/ath9k/spectral.c:500:24: warning:
> symbol 'rfs_spec_scan_cb' was not declared. Should it be static?

Thanks. This was also reported by the 0-day kbuild test.

Sujith