2012-06-04 23:49:09

by Javier Cardona

[permalink] [raw]
Subject: Re: [PATCH] mac80211: The station fail average is not updated correctly since the IEEE80211_STAT_ACK flag is not set when using wmediumd with mac80211_hwsim. Set this flag when wmediumd indicates that the frame was successfully transmitted (eventuall

Quasim,

On Mon, Jun 4, 2012 at 8:03 PM, Qasim Javed <[email protected]> wrote:
> Signed-off-by: Qasim Javed <[email protected]>

The fix looks correct but you will have to reformat the patch: it
looks like the commit log made it into the Subject line of your patch:

Subject: [PATCH] mac80211: The station fail average is not updated
correctly since the IEEE80211_STAT_ACK flag is not set when using
wmediumd with mac80211_hwsim. Set this flag when wmediumd indicates
that the frame was successfully transmitted (eventually).

You probably want:

```
Subject: [PATCH] mac80211_hwsim: Set IEEE80211_STAT_ACK when userspace
indicates the frame has been acknowledged.

The station fail average is not updated correctly since the
IEEE80211_STAT_ACK flag is not set when using wmediumd with
mac80211_hwsim. Set this flag when wmediumd indicates that the frame
was successfully transmitted (eventually).
```

Cheers,

> ---
> ?drivers/net/wireless/mac80211_hwsim.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
> index 4c9336c..a0b7cfd 100644
> --- a/drivers/net/wireless/mac80211_hwsim.c
> +++ b/drivers/net/wireless/mac80211_hwsim.c
> @@ -1555,6 +1555,7 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2,
> ? ? ? ? ? ? ? ? ? ? ? ?hdr = (struct ieee80211_hdr *) skb->data;
> ? ? ? ? ? ? ? ? ? ? ? ?mac80211_hwsim_monitor_ack(data2->hw, hdr->addr2);
> ? ? ? ? ? ? ? ?}
> + ? ? ? ? ? ? ? txi->flags |= IEEE80211_TX_STAT_ACK;
> ? ? ? ?}
> ? ? ? ?ieee80211_tx_status_irqsafe(data2->hw, skb);
> ? ? ? ?return 0;
> --
> 1.7.8.2
>



--
Javier Cardona
cozybit Inc.
http://www.cozybit.com