2012-08-26 22:26:49

by Marc Kleine-Budde

[permalink] [raw]
Subject: [PATCH] rt2x00: fix votage setting for RT3572/RT3592

According to the vendor driver v2.6.0.1, during the rf register init the SRAM
voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.

Cc: Gertjan van Wingerde <[email protected]>
Signed-off-by: Marc Kleine-Budde <[email protected]>
---
Hello,

I don't have the hardware to test, just stumbled over this while hacking on the
rt3593.

regards, Marc

drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index cb8c2ac..b93516d 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
msleep(1);
rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
+ rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
}
--
1.7.10



2012-08-27 08:19:11

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592

On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <[email protected]> wrote:
> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>
> Cc: Gertjan van Wingerde <[email protected]>
> Signed-off-by: Marc Kleine-Budde <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

> ---
> Hello,
>
> I don't have the hardware to test, just stumbled over this while hacking on the
> rt3593.
>
> regards, Marc
>
> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index cb8c2ac..b93516d 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
> msleep(1);
> rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
> + rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
> rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
> }
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-09-05 08:33:34

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592

On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <[email protected]> wrote:
>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>
>> Cc: Gertjan van Wingerde <[email protected]>
>> Signed-off-by: Marc Kleine-Budde <[email protected]>
>
> Acked-by: Ivo van Doorn <[email protected]>

Ping. Is someone taking care of this patch?

Marc

>
>> ---
>> Hello,
>>
>> I don't have the hardware to test, just stumbled over this while hacking on the
>> rt3593.
>>
>> regards, Marc
>>
>> drivers/net/wireless/rt2x00/rt2800lib.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index cb8c2ac..b93516d 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
>> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>> msleep(1);
>> rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
>> + rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
>> rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
>> rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>> }
>> --
>> 1.7.10
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


2012-09-05 20:19:06

by Gertjan van Wingerde

[permalink] [raw]
Subject: Re: [PATCH] rt2x00: fix votage setting for RT3572/RT3592

Marc,

Sent from my iPad

On 5 sep. 2012, at 10:33, Marc Kleine-Budde <[email protected]> wrote:

> On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
>> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <[email protected]> wrote:
>>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>>
>>> Cc: Gertjan van Wingerde <[email protected]>
>>> Signed-off-by: Marc Kleine-Budde <[email protected]>
>>
>> Acked-by: Ivo van Doorn <[email protected]>
>
> Ping. Is someone taking care of this patch?
>

Normally, John takes these patches after Ivo, Helmut or I have acked them.
However, I believe he was travelling last week, so it takes a bit longer to be applied.

---
Gertjan