2022-04-29 17:22:01

by Srinivasan Raju

[permalink] [raw]
Subject: [PATCH] [v3] plfxlc: fix le16_to_cpu warning for beacon_interval

Fix the following sparse warnings:
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Srinivasan Raju <[email protected]>
---
drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
index a5ec10b66ed5..f4ef9ff97146 100644
--- a/drivers/net/wireless/purelifi/plfxlc/chip.c
+++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
@@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
u8 dtim_period, int type)
{
if (!interval ||
- (chip->beacon_set &&
- le16_to_cpu(chip->beacon_interval) == interval))
+ (chip->beacon_set && chip->beacon_interval == interval))
return 0;

- chip->beacon_interval = cpu_to_le16(interval);
+ chip->beacon_interval = interval;
chip->beacon_set = true;
return plfxlc_usb_wreq(chip->usb.ez_usb,
&chip->beacon_interval,
--
2.25.1


2022-05-02 23:06:26

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] [v3] plfxlc: fix le16_to_cpu warning for beacon_interval

Srinivasan Raju <[email protected]> wrote:

> Fix the following sparse warnings:
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Srinivasan Raju <[email protected]>

Failed to apply, please rebase on top of wireless-next. And also I
strongly recommend to use git send-email for avoiding any formatting
problems.

error: patch failed: drivers/net/wireless/purelifi/plfxlc/chip.c:29
error: drivers/net/wireless/purelifi/plfxlc/chip.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: plfxlc: fix le16_to_cpu warning for beacon_interval
Using index info to reconstruct a base tree...
Patch failed at 0001 plfxlc: fix le16_to_cpu warning for beacon_interval

Patch set to Changes Requested.

--
https://patchwork.kernel.org/project/linux-wireless/patch/CWLP265MB3217FDFE8E945E52492B002FE0FC9@CWLP265MB3217.GBRP265.PROD.OUTLOOK.COM/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches