2016-01-18 09:50:08

by Guy Mishol

Subject: [PATCH] wlcore: fix return value of wlcore_event_fw_logger

The function can return negative values in case of error.
Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")

Signed-off-by: Guy Mishol <[email protected]>
---
drivers/net/wireless/ti/wlcore/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c
index c964054..4b59f67 100644
--- a/drivers/net/wireless/ti/wlcore/event.c
+++ b/drivers/net/wireless/ti/wlcore/event.c
@@ -38,7 +38,7 @@

int wlcore_event_fw_logger(struct wl1271 *wl)
{
- u32 ret;
+ int ret;
struct fw_logger_information fw_log;
u8 *buffer;
u32 internal_fw_addrbase = WL18XX_DATA_RAM_BASE_ADDRESS;
--
2.6.4

2016-01-21 13:54:21

by Guy Mishol

Subject: Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger

Cool. Thanks!

Sent from my iPhone

> On Jan 21, 2016, at 15:52, Kalle Valo <[email protected]> wrote:
>
> Guy Mishol <[email protected]> writes:
>
>> The function can return negative values in case of error.
>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>
>> Signed-off-by: Guy Mishol <[email protected]>
>
> Andrzej already submitted identical patch:
>
> https://patchwork.kernel.org/patch/7977461/
>
> So I'm dropping this.
>
> --
> Kalle Valo

2016-01-21 13:52:52

by Kalle Valo

Subject: Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger

Guy Mishol <[email protected]> writes:

> The function can return negative values in case of error.
> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>
> Signed-off-by: Guy Mishol <[email protected]>

Andrzej already submitted identical patch:

https://patchwork.kernel.org/patch/7977461/

So I'm dropping this.

--
Kalle Valo