2015-08-03 12:51:38

by David Binderman

[permalink] [raw]
Subject: linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c: Bad test ?

Hello there,

[linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1542] -> [linux-4.2-rc5/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:1545]: (style) Mismatching assignment and comparison, comparison 'bt_pri==4294967295' is always false.

??? bt_pri = bt_pri & 0x00ffffff;

?? if (bt_tx == 0xffffffff && bt_pri == 0xffffffff &&

Six f in the first line, but eight in the second.

Would use of symbol constants help prevent this kind of problem occurring
in future ?


Regards

David Binderman