2023-11-24 19:32:23

by Johannes Berg

Subject: Re: [PATCH 6/6] wifi: mac80211_hwsim: Add custom reg for DFS concurrent

On Mon, 2023-11-13 at 11:35 +0200, [email protected] wrote:
>
> +static const struct ieee80211_regdomain hwsim_world_regdom_custom_04 = {
> + .n_reg_rules = 6,
> + .alpha2 = "99",
> + .reg_rules = {
> + REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0),
> + REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20, 0),
> + REG_RULE(5150 - 10, 5240 + 10, 80, 0, 30, 0),

Didn't you say that could be 160? But that'd need merging with the next
range or auto-bw.

> + /* TODO: Add param */
> + wiphy_ext_feature_set(hw->wiphy,
> + NL80211_EXT_FEATURE_DFS_CONCURRENT);

Hm, yes? :)

johannes

2023-11-28 08:39:37

by Andrei Otcheretianski

Subject: RE: [PATCH 6/6] wifi: mac80211_hwsim: Add custom reg for DFS concurrent

> > +static const struct ieee80211_regdomain
> hwsim_world_regdom_custom_04 = {
> > + .n_reg_rules = 6,
> > + .alpha2 = "99",
> > + .reg_rules = {
> > + REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0),
> > + REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20, 0),
> > + REG_RULE(5150 - 10, 5240 + 10, 80, 0, 30, 0),
>
> Didn't you say that could be 160? But that'd need merging with the next
> range or auto-bw.

The entire range here is 80, so 160 doesn't make sense here.
I will add auto_bw here similar to what we have in world_regdom.
And also the second DFS range with 160.

>
> > + /* TODO: Add param */
> > + wiphy_ext_feature_set(hw->wiphy,
> > + NL80211_EXT_FEATURE_DFS_CONCURRENT);
>
> Hm, yes? :)

Actually, as ,mac80211_hwsim should be anyway started with custom regdom, I don't think now that an addition module param is still needed.
I will just remove the TODO here.

>
> johannes