2019-06-05 09:18:17

by Ganapathi Bhat

[permalink] [raw]
Subject: RE: [EXT] [PATCH 1/2] mwifiex: dispatch/rotate from reorder table atomically

Hi Brian,

> (1) iterating / clearing the mwifiex reordering table
> (2) dispatching received packets to upper layers
>
> This makes it much harder to make lock recursion mistakes, as these two
> steps no longer need to hold the same locks.

Yes, this is clean;

>
> Testing: I've played with a variety of stress tests, including download stress
> tests on the same APs which caught regressions with commit
> 5188d5453bc9 ("mwifiex: restructure rx_reorder_tbl_lock usage"). I've
> primarily tested on Marvell 8997 / PCIe, although I've given 8897 / SDIO a
> quick spin as well.
>

Thanks a lot for this; We will also run the tests locally; But, I find the change is good;

Acked-by: Ganapathi Bhat <[email protected]>

Regards,
Ganapathi