2008-03-12 07:40:37

by Masakazu Mokuno

[permalink] [raw]
Subject: [PATCH] PS3: gelic: change the prefix of the net interface for wireless

The gelic driver uses two net interfaces, one for ethernet and the
other for wireless. They share same MAC address and use 'eth' prefix
for the name.
As udev uses the MAC address to check uniqueness, this is
somewhat problematic. So change the prefix of the network interface
name for the wireless so that udev can have an easy way to distinguish
interfaces.

Signed-off-by: Masakazu Mokuno <[email protected]>
---
drivers/net/ps3_gelic_wireless.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2389,6 +2389,8 @@ static struct net_device *gelic_wl_alloc
if (!netdev)
return NULL;

+ strcpy(netdev->name, "wlan%d");
+
port = netdev_priv(netdev);
port->netdev = netdev;
port->card = card;



2008-03-12 10:26:57

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] PS3: gelic: change the prefix of the net interface for wireless

On Wed, 12 Mar 2008, Masakazu Mokuno wrote:
> The gelic driver uses two net interfaces, one for ethernet and the
> other for wireless. They share same MAC address and use 'eth' prefix
> for the name.
> As udev uses the MAC address to check uniqueness, this is
> somewhat problematic. So change the prefix of the network interface
> name for the wireless so that udev can have an easy way to distinguish
> interfaces.

Now my PS3 has `eth0' and `wlan0_rename'.
I assume we still need changes to udev?

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/

Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

2008-03-12 10:57:00

by Masakazu Mokuno

[permalink] [raw]
Subject: Re: [PATCH] PS3: gelic: change the prefix of the net interface for wireless


On Wed, 12 Mar 2008 11:26:54 +0100 (CET)
Geert Uytterhoeven <[email protected]> wrote:

> On Wed, 12 Mar 2008, Masakazu Mokuno wrote:
> > The gelic driver uses two net interfaces, one for ethernet and the
> > other for wireless. They share same MAC address and use 'eth' prefix
> > for the name.
> > As udev uses the MAC address to check uniqueness, this is
> > somewhat problematic. So change the prefix of the network interface
> > name for the wireless so that udev can have an easy way to distinguish
> > interfaces.
>
> Now my PS3 has `eth0' and `wlan0_rename'.
> I assume we still need changes to udev?

The patch just gives a clue to write nicer rule in udev.
My previous fix for this issue was to add an exception to udev like:

--- 75-persistent-net-generator.rules.orig 2008-03-04 14:17:07.000000000 +0900
+++ 75-persistent-net-generator.rules 2008-03-04 14:03:23.000000000 +0900
@@ -23,6 +23,9 @@
# ignore Xen virtual interfaces
SUBSYSTEMS=="xen", GOTO="persistent_net_generator_end"

+# ignore PS3 gelic interfaces; they share a mac address
+DRIVERS=="ps3_gelic_driver", GOTO="persistent_net_generator_end"
+
# read MAC address
ENV{MATCHADDR}="$attr{address}"

But Kay Sievers <[email protected]> told that he could add a nicer
rule if the wireless interface has the distinct prefix like 'wlan'. So
I made this patch.

--
Masakazu MOKUNO