2022-10-11 10:03:06

by Heiko Carstens

[permalink] [raw]
Subject: Re: [PATCH v6 4/7] treewide: use get_random_{u8,u16}() when possible, part 2

On Mon, Oct 10, 2022 at 05:06:10PM -0600, Jason A. Donenfeld wrote:
> Rather than truncate a 32-bit value to a 16-bit value or an 8-bit value,
> simply use the get_random_{u8,u16}() functions, which are faster than
> wasting the additional bytes from a 32-bit value. This was done by hand,
> identifying all of the places where one of the random integer functions
> was used in a non-32-bit context.
>
> Reviewed-by: Greg Kroah-Hartman <[email protected]>
> Reviewed-by: Kees Cook <[email protected]>
> Reviewed-by: Yury Norov <[email protected]>
> Signed-off-by: Jason A. Donenfeld <[email protected]>
> ---
> arch/s390/kernel/process.c | 2 +-

For s390:
Acked-by: Heiko Carstens <[email protected]>