2021-10-21 06:33:56

by Kevin Lo

Subject: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
it should return -EFAULT rather than 0. Otherwise, the function doesn't need
to exist.

Signed-off-by: Kevin Lo <[email protected]>
---
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 69384c43c046..afcd07ab1de7 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;

if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
- return 0;
+ return -EFAULT;

return 0;
}

2021-10-22 00:27:14

by Ping-Ke Shih

Subject: RE: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

> -----Original Message-----
> From: Kevin Lo <[email protected]>
> Sent: Thursday, October 21, 2021 2:32 PM
> To: [email protected]
> Cc: Pkshih <[email protected]>
> Subject: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk
>
> It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
> it should return -EFAULT rather than 0. Otherwise, the function doesn't need
> to exist.
>
> Signed-off-by: Kevin Lo <[email protected]>

Acked-by: Ping-Ke Shih <[email protected]>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 69384c43c046..afcd07ab1de7 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
> const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;
>
> if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
> - return 0;
> + return -EFAULT;

Fortunately, current checking is always equal, so it doesn't affect the result.

>
> return 0;
> }


--
Ping-Ke

2021-10-27 18:53:47

by Kalle Valo

Subject: Re: [PATCH wireless-drivers-next] rtw89: fix return value in hfc_pub_cfg_chk

Kevin Lo <[email protected]> wrote:

> It seems to me when pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max is true,
> it should return -EFAULT rather than 0. Otherwise, the function doesn't need
> to exist.
>
> Signed-off-by: Kevin Lo <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 69384c43c046..afcd07ab1de7 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -560,7 +560,7 @@ static int hfc_pub_cfg_chk(struct rtw89_dev *rtwdev)
> const struct rtw89_hfc_pub_cfg *pub_cfg = &param->pub_cfg;
>
> if (pub_cfg->grp0 + pub_cfg->grp1 != pub_cfg->pub_max)
> - return 0;
> + return -EFAULT;
>
> return 0;
> }

Patch applied to wireless-drivers-next.git, thanks.

c6477cb23704 rtw89: fix return value in hfc_pub_cfg_chk

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches