2022-01-14 14:39:23

by Bo Jiao

Subject: [PATCH v3 1/4] dt-bindings: net: wireless: mt76: document bindings for MT7986

From: Peter Chiu <[email protected]>

Add an entry for MT7986 SoC.

Signed-off-by: Peter Chiu <[email protected]>
Cc: [email protected]
---
v3:
- fix yamllint warnings and errors
- add 'minItems: 1' to keep 1 reg entry being valid
---
.../bindings/net/wireless/mediatek,mt76.yaml | 31 +++++++++++++++++--
1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 1489d3c..d630a7e 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -18,7 +18,7 @@ description: |
wireless device. The node is expected to be specified as a child
node of the PCI controller to which the wireless chip is connected.
Alternatively, it can specify the wireless part of the MT7628/MT7688
- or MT7622 SoC.
+ or MT7622/MT7986 SoC.

allOf:
- $ref: ieee80211.yaml#
@@ -29,9 +29,11 @@ properties:
- mediatek,mt76
- mediatek,mt7628-wmac
- mediatek,mt7622-wmac
+ - mediatek,mt7986-wmac

reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 3

interrupts:
maxItems: 1
@@ -39,6 +41,17 @@ properties:
power-domains:
maxItems: 1

+ memory-region:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+ description:
+ Specify the consys reset for mt7986.
+
+ reset-name:
+ const: consys
+
mediatek,infracfg:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -165,7 +178,7 @@ required:
- compatible
- reg

-additionalProperties: false
+unevaluatedProperties: false

examples:
- |
@@ -231,3 +244,15 @@ examples:

power-domains = <&scpsys 3>;
};
+
+ - |
+ wifi@18000000 {
+ compatible = "mediatek,mt7986-wmac";
+ resets = <&watchdog 23>;
+ reset-names = "consys";
+ reg = <0x18000000 0x1000000>,
+ <0x10003000 0x1000>,
+ <0x11d10000 0x1000>;
+ interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
+ memory-region = <&wmcpu_emi>;
+ };
--
2.18.0

2022-02-07 16:19:14

by Rob Herring

Subject: Re: [PATCH v3 1/4] dt-bindings: net: wireless: mt76: document bindings for MT7986

On Fri, Jan 14, 2022 at 10:53:20AM +0800, Bo Jiao wrote:
> From: Peter Chiu <[email protected]>
>
> Add an entry for MT7986 SoC.
>
> Signed-off-by: Peter Chiu <[email protected]>
> Cc: [email protected]
> ---
> v3:
> - fix yamllint warnings and errors
> - add 'minItems: 1' to keep 1 reg entry being valid
> ---
> .../bindings/net/wireless/mediatek,mt76.yaml | 31 +++++++++++++++++--
> 1 file changed, 28 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 1489d3c..d630a7e 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -18,7 +18,7 @@ description: |
> wireless device. The node is expected to be specified as a child
> node of the PCI controller to which the wireless chip is connected.
> Alternatively, it can specify the wireless part of the MT7628/MT7688
> - or MT7622 SoC.
> + or MT7622/MT7986 SoC.
>
> allOf:
> - $ref: ieee80211.yaml#
> @@ -29,9 +29,11 @@ properties:
> - mediatek,mt76
> - mediatek,mt7628-wmac
> - mediatek,mt7622-wmac
> + - mediatek,mt7986-wmac
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 3

With more than 1, you need to define what each one is.

>
> interrupts:
> maxItems: 1
> @@ -39,6 +41,17 @@ properties:
> power-domains:
> maxItems: 1
>
> + memory-region:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> + description:
> + Specify the consys reset for mt7986.
> +
> + reset-name:
> + const: consys
> +
> mediatek,infracfg:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -165,7 +178,7 @@ required:
> - compatible
> - reg
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> @@ -231,3 +244,15 @@ examples:
>
> power-domains = <&scpsys 3>;
> };
> +
> + - |
> + wifi@18000000 {
> + compatible = "mediatek,mt7986-wmac";
> + resets = <&watchdog 23>;
> + reset-names = "consys";
> + reg = <0x18000000 0x1000000>,
> + <0x10003000 0x1000>,
> + <0x11d10000 0x1000>;
> + interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
> + memory-region = <&wmcpu_emi>;
> + };
> --
> 2.18.0
>
>