2023-05-05 23:01:51

by Tejun Heo

Subject: [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq

trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need
explicit concurrency limit. Let's use the default @max_active. This doesn't
cost anything and clearly expresses that @max_active doesn't matter.

Signed-off-by: Tejun Heo <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Gregory Greenman <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Avraham Stern <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Mordechay Goodstein <[email protected]>
Cc: "Haim, Dreyfuss" <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
Hello,

Johannes, do you mind acking this patch instead?

Thanks.

drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s
init_waitqueue_head(&trans_pcie->imr_waitq);

trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
- WQ_HIGHPRI | WQ_UNBOUND, 1);
+ WQ_HIGHPRI | WQ_UNBOUND, 0);
if (!trans_pcie->rba.alloc_wq) {
ret = -ENOMEM;
goto out_free_trans;

2023-05-08 16:08:38

by Johannes Berg

Subject: Re: [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq

On Fri, 2023-05-05 at 12:52 -1000, Tejun Heo wrote:
> trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't need
> explicit concurrency limit. Let's use the default @max_active. This doesn't
> cost anything and clearly expresses that @max_active doesn't matter.
>
> Signed-off-by: Tejun Heo <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> Cc: Gregory Greenman <[email protected]>
> Cc: Johannes Berg <[email protected]>
> Cc: Avraham Stern <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Mordechay Goodstein <[email protected]>
> Cc: "Haim, Dreyfuss" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
>

Sure, that seems fine too.

Acked-by: Johannes Berg <[email protected]>

For whatever that's worth, might better to get Gregory ;-)

johannes

> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s
> init_waitqueue_head(&trans_pcie->imr_waitq);
>
> trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
> - WQ_HIGHPRI | WQ_UNBOUND, 1);
> + WQ_HIGHPRI | WQ_UNBOUND, 0);
> if (!trans_pcie->rba.alloc_wq) {
> ret = -ENOMEM;
> goto out_free_trans;
>