2023-12-01 10:18:05

by Francesco Dolcini

[permalink] [raw]
Subject: Re: [PATCH v7 03/12] wifi: mwifiex: fixed reassocation issue for WPA3.

On Tue, Nov 28, 2023 at 04:31:06PM +0800, David Lin wrote:
> This issue is related to resatart/reconfigure AP.
>
> When AP is restarted or reconfigured, wpa_supplilcant will use cached
> PMKSA to do association to AP.
> Because association failure does not report to cfg80211/wpa_supplicant,
> wpa_supplicant will always use cached PMKSA to do assocaiton.
> Connection can't be established under this way.

Same comment as patch 2, this seems a fixup of commit 1, you should fix
that patch, not add a followup fixup commit.

Francesco



2023-12-01 22:44:51

by David Lin

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v7 03/12] wifi: mwifiex: fixed reassocation issue for WPA3.

> From: Francesco Dolcini <[email protected]>
> Sent: Friday, December 1, 2023 6:18 PM
> To: David Lin <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Pete
> Hsieh <[email protected]>
> Subject: [EXT] Re: [PATCH v7 03/12] wifi: mwifiex: fixed reassocation issue for
> WPA3.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Tue, Nov 28, 2023 at 04:31:06PM +0800, David Lin wrote:
> > This issue is related to resatart/reconfigure AP.
> >
> > When AP is restarted or reconfigured, wpa_supplilcant will use cached
> > PMKSA to do association to AP.
> > Because association failure does not report to
> > cfg80211/wpa_supplicant, wpa_supplicant will always use cached PMKSA
> to do assocaiton.
> > Connection can't be established under this way.
>
> Same comment as patch 2, this seems a fixup of commit 1, you should fix
> that patch, not add a followup fixup commit.
>

This patch is due to QA test result of patch 1, I wonder why this patch should be merged with patch 1?

> Francesco