2024-06-05 14:38:50

by Andreas Kemnade

[permalink] [raw]
Subject: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

Hi,

I am a bit wondering, but there is mrvl/sd8987_uapsta.bin
referenced in the driver, but apperently it is not in the firmware git.

https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_8987/sdiouart8987_combo_v0.bin

seems to apparently work. How to proceed? Should the file be renamed and added
to the fw git?
The uartuart8987_bt.bin needed by the btnxpuart driver is there.

It is just nasty to have a driver for a device but some manual matching of firmware

BTW: there is also https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_8987/sd8987_wlan.bin

Regards,
Andreas


2024-06-05 14:51:53

by Tamás Szűcs

[permalink] [raw]
Subject: Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

Hi Andreas,

Excellent point. Please note, that btmrvl_sdio needs an SDIO BT FW. So, mrvl/sd8987_uapsta.bin should preferably be a such a combo FW.

Unfortunately, to my knowledge, none is available publicly. Also, after the acquisition of Marvell IoT, NXP regrettably decided to develop mwifiex downstream, here https://github.com/nxp-imx/mwifiex.

It is what it is. Due to licensing, the FW binary should come from NXP. I cannot arrange that.

Kind regards,
Tamas



Tamás Szűcs
[email protected]


Sent with Proton Mail secure email.

On Wednesday, June 5th, 2024 at 4:00 PM, Andreas Kemnade <[email protected]> wrote:

> Hi,
>
> I am a bit wondering, but there is mrvl/sd8987_uapsta.bin
> referenced in the driver, but apperently it is not in the firmware git.
>
> https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_8987/sdiouart8987_combo_v0.bin
>
> seems to apparently work. How to proceed? Should the file be renamed and added
> to the fw git?
> The uartuart8987_bt.bin needed by the btnxpuart driver is there.
>
> It is just nasty to have a driver for a device but some manual matching of firmware
>
> BTW: there is also https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_8987/sd8987_wlan.bin
>
> Regards,
> Andreas

2024-06-05 16:12:37

by Andreas Kemnade

[permalink] [raw]
Subject: Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

Am Wed, 05 Jun 2024 14:43:53 +0000
schrieb Tamás Szűcs <[email protected]>:

> Hi Andreas,
>
> Excellent point. Please note, that btmrvl_sdio needs an SDIO BT FW.
> So, mrvl/sd8987_uapsta.bin should preferably be a such a combo FW.
>
as said the firmware here seems to work for me (after renaming):
https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_8987/sdiouart8987_combo_v0.bin

I can use bluetooth together with btnxpuart driver and firmware
/lib/firmware/nxp/uartuart8987_bt.bin which is officially part of
linux-firmware and also in the same directory in the imx-firmware git
mentioned above.

> Unfortunately, to my knowledge, none is available publicly. Also,
> after the acquisition of Marvell IoT, NXP regrettably decided to
> develop mwifiex downstream, here https://github.com/nxp-imx/mwifiex.
>
> It is what it is. Due to licensing, the FW binary should come from
> NXP. I cannot arrange that.

Regarding license I found that snippet in nxp/SCR_nxp.txt:
Package: FwImage_8997, FwImage_8987, FwImage_8801,
FwImage_9098, FwImage_IW416, FwImage_IW612 Outgoing License:
LA_OPT_NXP_Software_License - Production Use, Section 2.3 applies
License File: EULA.txt

Section 2.3 is:
2.3. Additional Distribution License

But that is all legalese and I am not a lawyer... Best is of course
something officially added from NXP. No idea if it can be done
otherwise. How to make NXP add something?

Regards,
Andreas

2024-06-06 10:19:07

by Francesco Dolcini

[permalink] [raw]
Subject: Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

+Neeraj

Hello David, hello Neeraj

On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> But that is all legalese and I am not a lawyer... Best is of course
> something officially added from NXP. No idea if it can be done
> otherwise. How to make NXP add something?

Would it be possible for you to get these firmware files added to the
official linux-firmware git repo?

I am not using sd8987 myself, from what I read in the thread probably
some file name would need to be corrected (I would say in the mwifiex
driver).

Thanks,
Francesco


2024-06-06 13:50:11

by Lukas Wunner

[permalink] [raw]
Subject: Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

[add more interested parties to cc]

On Thu, Jun 06, 2024 at 12:18:39PM +0200, Francesco Dolcini wrote:
> On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> > But that is all legalese and I am not a lawyer... Best is of course
> > something officially added from NXP. No idea if it can be done
> > otherwise. How to make NXP add something?
>
> Would it be possible for you to get these firmware files added to the
> official linux-firmware git repo?
>
> I am not using sd8987 myself, from what I read in the thread probably
> some file name would need to be corrected (I would say in the mwifiex
> driver).

I'd appreciate if NXP could additionally greenlight addition of:

https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_IW416_SD/sdiouartiw416_combo_v0.bin
https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/nxp/FwImage_IW416_SD/uartiw416_bt_v0.bin

...to the linux-firmware repo. They're necessary for SD8978 (aka IW416),
which has been supported by mwifiex since commit bba047f15851 ("wifi:
mwifiex: Support SD8978 chipset").

Back in the day when I submitted that commit, I concurrently reached out
to NXP. Sherry Sun kindly responded that Dinesh Phatak and Pankaj
Razdan need to confirm upstreaming into linux-firmware (both +cc).


The problem is that mwifiex firmware originating from

https://github.com/NXP/mwifiex-firmware/

is available under a simple 3-clause licence, but only contains outdated
firmware for older chips.


More recent firmware available from

https://github.com/nxp-imx/imx-firmware

seems to be distributed under different and much longer licensing terms:

https://github.com/nxp-imx/imx-firmware/blob/lf-6.6.3_1.0.0/LICENSE.txt

So I think we need confirmation from NXP before we can add the firmware
to the linux-firmware repo.

Thanks,

Lukas

2024-06-12 02:39:50

by David Lin

[permalink] [raw]
Subject: RE: [EXT] Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

> From: Francesco Dolcini <[email protected]>
> Sent: Thursday, June 6, 2024 6:19 PM
> To: Andreas Kemnade <[email protected]>; David Lin
> <[email protected]>; Neeraj Sanjay Kale <[email protected]>
> Cc: Tam?s Sz?cs <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [EXT] Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the
> firmware git
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> +Neeraj
>
> Hello David, hello Neeraj
>
> On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> > But that is all legalese and I am not a lawyer... Best is of course
> > something officially added from NXP. No idea if it can be done
> > otherwise. How to make NXP add something?
>
> Would it be possible for you to get these firmware files added to the official
> linux-firmware git repo?
>
> I am not using sd8987 myself, from what I read in the thread probably some
> file name would need to be corrected (I would say in the mwifiex driver).
>
> Thanks,
> Francesco

I am not responsible for firmware release.

You can get updated firmware from https://github.com/nxp-imx/imx-firmware/.

Normally the firmware will be merged to NXP Yocto project.

Thanks,
David

2024-06-12 06:48:22

by Francesco Dolcini

[permalink] [raw]
Subject: Re: [EXT] Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

Hello David,

On Wed, Jun 12, 2024 at 02:17:46AM +0000, David Lin wrote:
> > From: Francesco Dolcini <[email protected]>
> > On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> > > But that is all legalese and I am not a lawyer... Best is of course
> > > something officially added from NXP. No idea if it can be done
> > > otherwise. How to make NXP add something?
> >
> > Would it be possible for you to get these firmware files added to the official
> > linux-firmware git repo?
> >
> > I am not using sd8987 myself, from what I read in the thread probably some
> > file name would need to be corrected (I would say in the mwifiex driver).
>
> I am not responsible for firmware release.
> You can get updated firmware from https://github.com/nxp-imx/imx-firmware/.
Yes, I am aware of both, and most of the people in this thread is aware of the second.

I was wondering if you could facilitate within NXP having these firmware files
added to the linux firmware git repository, where they should be for various
reasons. To whom should I write such a request? Can you help in any way?

Francesco


2024-06-12 07:40:23

by Andreas Kemnade

[permalink] [raw]
Subject: Re: [EXT] Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

On Wed, 12 Jun 2024 02:17:46 +0000
David Lin <[email protected]> wrote:

> > From: Francesco Dolcini <[email protected]>
> > Sent: Thursday, June 6, 2024 6:19 PM
> > To: Andreas Kemnade <[email protected]>; David Lin
> > <[email protected]>; Neeraj Sanjay Kale <[email protected]>
> > Cc: Tamás Szűcs <[email protected]>; [email protected];
> > [email protected]; [email protected];
> > [email protected]; [email protected]
> > Subject: [EXT] Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the
> > firmware git
> >
> > Caution: This is an external email. Please take care when clicking links or
> > opening attachments. When in doubt, report the message using the 'Report
> > this email' button
> >
> >
> > +Neeraj
> >
> > Hello David, hello Neeraj
> >
> > On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> > > But that is all legalese and I am not a lawyer... Best is of course
> > > something officially added from NXP. No idea if it can be done
> > > otherwise. How to make NXP add something?
> >
> > Would it be possible for you to get these firmware files added to the official
> > linux-firmware git repo?
> >
> > I am not using sd8987 myself, from what I read in the thread probably some
> > file name would need to be corrected (I would say in the mwifiex driver).
> >
> > Thanks,
> > Francesco
>
> I am not responsible for firmware release.
>
> You can get updated firmware from https://github.com/nxp-imx/imx-firmware/.
>
> Normally the firmware will be merged to NXP Yocto project.
>
yes, I think most of us are aware of this.
So what is the problem: E.g. I have bought a new device, ported a linux distro
to it, ok, for my personal use, I can just download the firmware from
mentioned link. So now I want to pave the road for others so that wifi
"just works" So the question is about redistributing the firmware:

Citing License:
"(b) to copy and distribute as needed, solely in connection with an
Authorized System and for use in combination with a NXP Product,
non-confidential NXP information provided as part of the Licensed Software for
the purpose of maintaining and supporting Authorized Systems with which the
Licensed Software is integrated."

to me it looks like the firmware might not allowed to be part of a linux
distribution if that linux distribution is not just for one device.
So an official permission to do so is really helpful. The most clearest
thing would be an addition of the files to the official linux firmware
repo (git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git)
by some NXP people.

Regards,
Andreas

2024-06-14 05:42:39

by Neeraj Sanjay Kale

[permalink] [raw]
Subject: Re: mwifiex firmware mrvl/sd8987_uapsta.bin missing in the firmware git

++ Pushkar, Pete, Amit, Pankaj in CC

Hi Francesco,

I am not responsible for mwifiex or wifi firmware aspects, but I have forwarded this query internally within NXP and added few stakeholders in CC who can comment in this regards.

Thanks,
Neeraj

> > > Hello David, hello Neeraj
> > >
> > > On Wed, Jun 05, 2024 at 05:47:09PM +0200, Andreas Kemnade wrote:
> > > > But that is all legalese and I am not a lawyer... Best is of
> > > > course something officially added from NXP. No idea if it can be
> > > > done otherwise. How to make NXP add something?
> > >
> > > Would it be possible for you to get these firmware files added to
> > > the official linux-firmware git repo?
> > >
> > > I am not using sd8987 myself, from what I read in the thread
> > > probably some file name would need to be corrected (I would say in the
> mwifiex driver).
> > >
> > > Thanks,
> > > Francesco
> >
> > I am not responsible for firmware release.
> >
> > You can get updated firmware from
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
> com%2Fnxp-imx%2Fimx-
> firmware%2F&data=05%7C02%7Cneeraj.sanjaykale%40nxp.com%7Cf6a593f3
> 0cbd4db4c25708dc8ab2e6c3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> %7C0%7C638537748179838808%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C40000
> %7C%7C%7C&sdata=3VpeUrG20NMjgFHNaN32m11zeyBobUX%2BBoeipSEUnz
> s%3D&reserved=0.
> >
> > Normally the firmware will be merged to NXP Yocto project.
> >
> yes, I think most of us are aware of this.
> So what is the problem: E.g. I have bought a new device, ported a linux distro
> to it, ok, for my personal use, I can just download the firmware from
> mentioned link. So now I want to pave the road for others so that wifi "just
> works" So the question is about redistributing the firmware:
>
> Citing License:
> "(b) to copy and distribute as needed, solely in connection with an
> Authorized System and for use in combination with a NXP Product, non-
> confidential NXP information provided as part of the Licensed Software for the
> purpose of maintaining and supporting Authorized Systems with which the
> Licensed Software is integrated."
>
> to me it looks like the firmware might not allowed to be part of a linux
> distribution if that linux distribution is not just for one device.
> So an official permission to do so is really helpful. The most clearest thing
> would be an addition of the files to the official linux firmware repo
> (git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git)
> by some NXP people.
>