2022-07-06 09:13:49

by Lian Chen

Subject: [PATCH] mt76: address4 null frame using fixed rate to trigger WDS

From: "lian.chen" <[email protected]>

WDS function need address4 package to trigger the AP create wlan0.sta.
while the address4 null frame is sent at a high rate.
the AP can not receive it.
so, using fixed rate to trigger WDS flow.

Signed-off-by: lian.chen <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
index 3ab0dcd..d83ed59 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
@@ -393,7 +393,8 @@ mt76_connac2_mac_write_txwi_80211(struct mt76_dev *dev, __le32 *txwi,
}

if (!ieee80211_is_data(fc) || multicast ||
- info->flags & IEEE80211_TX_CTL_USE_MINRATE)
+ info->flags & IEEE80211_TX_CTL_USE_MINRATE ||
+ (ieee80211_is_nullfunc(fc) && ieee80211_has_a4(fc)))
val |= MT_TXD2_FIX_RATE;

txwi[2] |= cpu_to_le32(val);
--
2.18.0

2022-07-06 13:16:07

by Felix Fietkau

Subject: Re: [PATCH] mt76: address4 null frame using fixed rate to trigger WDS

On 06.07.22 11:09, Lian Chen wrote:
> From: "lian.chen" <[email protected]>
>
> WDS function need address4 package to trigger the AP create wlan0.sta.
> while the address4 null frame is sent at a high rate.
> the AP can not receive it.
> so, using fixed rate to trigger WDS flow.
>
> Signed-off-by: lian.chen <[email protected]>
I think it might make more sense to set IEEE80211_TX_CTL_USE_MINRATE in
the mac80211 function ieee80211_send_4addr_nullfunc().

- Felix

2022-07-26 13:08:37

by Kalle Valo

Subject: Re: [PATCH] mt76: address4 null frame using fixed rate to trigger WDS

Lian Chen <[email protected]> writes:

> From: "lian.chen" <[email protected]>

Please don't use dot in your name and capitalise it as well. So this
should be:

From: "Lian Chen" <[email protected]>

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches