2019-11-15 15:07:10

by Lorenzo Bianconi

[permalink] [raw]
Subject: [PATCH 1/3] mt76: mt76x02: fix coverage_class type

Fix coverage_class definition in mt76x02_dev data structure since
coverage_class can be negative to enable dynack (just supported by
ath9k)

Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76x02.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02.h b/drivers/net/wireless/mediatek/mt76/mt76x02.h
index 0ca0bbfe8769..cdc1cbd1d392 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x02.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76x02.h
@@ -110,7 +110,7 @@ struct mt76x02_dev {

bool no_2ghz;

- u8 coverage_class;
+ s16 coverage_class;
u8 slottime;

struct mt76x02_dfs_pattern_detector dfs_pd;
--
2.21.0


2019-11-20 12:04:26

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH 1/3] mt76: mt76x02: fix coverage_class type

On 2019-11-15 16:05, Lorenzo Bianconi wrote:
> Fix coverage_class definition in mt76x02_dev data structure since
> coverage_class can be negative to enable dynack (just supported by
> ath9k)
>
> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
> Signed-off-by: Lorenzo Bianconi <[email protected]>
I'd prefer a patch that sets the internal coverage_class field value to
0 for negative input values.

- Felix

2019-11-20 12:09:20

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 1/3] mt76: mt76x02: fix coverage_class type

> On 2019-11-15 16:05, Lorenzo Bianconi wrote:
> > Fix coverage_class definition in mt76x02_dev data structure since
> > coverage_class can be negative to enable dynack (just supported by
> > ath9k)
> >
> > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e")
> > Signed-off-by: Lorenzo Bianconi <[email protected]>
> I'd prefer a patch that sets the internal coverage_class field value to
> 0 for negative input values.

ack, I will do in v2

Regards,
Lorenzo

>
> - Felix


Attachments:
(No filename) (499.00 B)
signature.asc (235.00 B)
Download all attachments