2017-12-02 09:54:19

by Kenneth Lu

Subject: [PATCH] ath6kl: improve endianness handling

Replace ntohs with be16_to_cpu to do endian conversions for ethhdr
h_proto assignment.

Signed-off-by: Kenneth Lu <[email protected]>
---
drivers/net/wireless/ath/ath6kl/txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/txrx.c b/drivers/net/wireless/ath/ath6kl/txrx.c
index 1379906..8da9506 100644
--- a/drivers/net/wireless/ath/ath6kl/txrx.c
+++ b/drivers/net/wireless/ath/ath6kl/txrx.c
@@ -1001,7 +1001,7 @@ static void aggr_slice_amsdu(struct aggr_info *p_aggr,

while (amsdu_len > mac_hdr_len) {
hdr = (struct ethhdr *) framep;
- payload_8023_len = ntohs(hdr->h_proto);
+ payload_8023_len = be16_to_cpu(hdr->h_proto);

if (payload_8023_len < MIN_MSDU_SUBFRAME_PAYLOAD_LEN ||
payload_8023_len > MAX_MSDU_SUBFRAME_PAYLOAD_LEN) {
--
2.7.4

2017-12-07 14:36:29

by Kalle Valo

Subject: Re: ath6kl: improve endianness handling

Kenneth Lu <[email protected]> wrote:

> Replace ntohs with be16_to_cpu to do endian conversions for ethhdr
> h_proto assignment.
>
> Signed-off-by: Kenneth Lu <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

5d24bcd56dc7 ath6kl: improve endianness handling

--
https://patchwork.kernel.org/patch/10088565/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches