2011-03-25 17:17:35

by Nicolas Pitre

Subject: Re: [PATCH v1 2/2] sdio: add power_restore support with MMC_PM_KEEP_POWER mode

On Sat, 26 Mar 2011, Wilson Loi wrote:

> Sorry, this is the first time I sent a patch.
>
> There are two case for the WLAN SDIO card to do power saving.
> 1. Totally cut off the power of WLAN network interface.
> 2. offload the network state to WLAN SDIO firmware.

Case #2 is already supported with current code. Patches for the
libertas driver are in the OLPC repository (no idea if they were
submitted upstream yet).


Nicolas

2011-03-25 17:52:53

by Chris Ball

Subject: Re: [PATCH v1 2/2] sdio: add power_restore support with MMC_PM_KEEP_POWER mode

Hi,

On Fri, Mar 25 2011, Nicolas Pitre wrote:
> On Sat, 26 Mar 2011, Wilson Loi wrote:
>
>> Sorry, this is the first time I sent a patch.
>>
>> There are two case for the WLAN SDIO card to do power saving.
>> 1. Totally cut off the power of WLAN network interface.
>> 2. offload the network state to WLAN SDIO firmware.
>
> Case #2 is already supported with current code. Patches for the
> libertas driver are in the OLPC repository (no idea if they were
> submitted upstream yet).

Yes, they're upstream now. libertas/if_sdio.c:if_sdio_suspend() sets
MMC_PM_KEEP_POWER if a wakeup source has been set with "ethtool wol".

- Chris.
--
Chris Ball <[email protected]> <http://printf.net/>
One Laptop Per Child