From: Ben Greear <[email protected]>
The 10.4 firmware defines this as a 3-bit field, as does the
mac80211 stack. The 4th bit is defined as CONF_IMPLICIT_BF
at least in the firmware header I have seen. This patch
fixes the ath10k wmi header to match the firmware.
Signed-off-by: Ben Greear <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index ff15c37..9522f22 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -5195,7 +5195,8 @@ enum wmi_10_4_vdev_param {
#define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3)
#define WMI_TXBF_STS_CAP_OFFSET_LSB 4
-#define WMI_TXBF_STS_CAP_OFFSET_MASK 0xf0
+#define WMI_TXBF_STS_CAP_OFFSET_MASK 0x70
+#define WMI_TXBF_CONF_IMPLICIT_BF BIT(7)
#define WMI_BF_SOUND_DIM_OFFSET_LSB 8
#define WMI_BF_SOUND_DIM_OFFSET_MASK 0xf00
--
2.4.11
Am 14.11.2017 um 18:16 schrieb [email protected]:
> From: Ben Greear <[email protected]>
>
> The 10.4 firmware defines this as a 3-bit field, as does the
> mac80211 stack. The 4th bit is defined as CONF_IMPLICIT_BF
> at least in the firmware header I have seen. This patch
> fixes the ath10k wmi header to match the firmware.
>
> Signed-off-by: Ben Greear <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/wmi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
> index ff15c37..9522f22 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.h
> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
> @@ -5195,7 +5195,8 @@ enum wmi_10_4_vdev_param {
> #define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3)
>
> #define WMI_TXBF_STS_CAP_OFFSET_LSB 4
> -#define WMI_TXBF_STS_CAP_OFFSET_MASK 0xf0
> +#define WMI_TXBF_STS_CAP_OFFSET_MASK 0x70
> +#define WMI_TXBF_CONF_IMPLICIT_BF BIT(7)
> #define WMI_BF_SOUND_DIM_OFFSET_LSB 8
> #define WMI_BF_SOUND_DIM_OFFSET_MASK 0xf00
i can validate this. good finding
>
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565
Ben Greear <[email protected]> wrote:
> The 10.4 firmware defines this as a 3-bit field, as does the
> mac80211 stack. The 4th bit is defined as CONF_IMPLICIT_BF
> at least in the firmware header I have seen. This patch
> fixes the ath10k wmi header to match the firmware.
>
> Signed-off-by: Ben Greear <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
8cec57f5277e ath10k: fix invalid STS_CAP_OFFSET_MASK
--
https://patchwork.kernel.org/patch/10057943/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches