This patch fixes a build warning in mwl8.c.
(Marvell TOPDOG wireless driver)
The warning it fixes is: "large integer implicitly truncated to unsigned type."
Signed-off-by: Rami Rosen <[email protected]>
--
(wireless-next)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 57a0268..8bc016c 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -893,8 +893,7 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw,
int index)
rx_desc->next_rx_desc_phys_addr =
cpu_to_le32(rxq->rx_desc_dma
+ nexti * sizeof(*rx_desc));
- rx_desc->rx_ctrl =
- cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
+ rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
}
return 0;
On Tue, Apr 21, 2009 at 02:32:00PM +0200, Johannes Berg wrote:
> On Tue, 2009-04-21 at 14:57 +0300, Rami Rosen wrote:
> > This patch fixes a build warning in mwl8.c.
> > (Marvell TOPDOG wireless driver)
> >
> > The warning it fixes is: "large integer implicitly truncated to unsigned type."
>
> > - rx_desc->rx_ctrl =
> > - cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
> > + rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
>
> Umm. This really needs to come with an explanation.
Yeah -- trading a warning for a silent error seems unreasonable. :-)
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Tue, 2009-04-21 at 14:57 +0300, Rami Rosen wrote:
> This patch fixes a build warning in mwl8.c.
> (Marvell TOPDOG wireless driver)
>
> The warning it fixes is: "large integer implicitly truncated to unsigned type."
> - rx_desc->rx_ctrl =
> - cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
> + rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
Umm. This really needs to come with an explanation.
johannes