With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
compatible devices in ath5k driver now includes the hardware present in this
computer, as well as the led pin and polarity.
--- ../led.c 2009-11-06 06:16:39.000000000 +0100
+++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
@@ -73,6 +73,8 @@
{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
/* IBM-specific AR5212 (all others) */
{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
+ /* Acer Aspire One D250 AR5007EG */
+ { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
{ }
};
On Fri, Nov 06, 2009 at 01:00:02PM +0000, Carlo Parata wrote:
> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
> compatible devices in ath5k driver now includes the hardware present in this
> computer, as well as the led pin and polarity.
>
> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
> @@ -73,6 +73,8 @@
> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> /* IBM-specific AR5212 (all others) */
> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
> + /* Acer Aspire One D250 AR5007EG */
> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
> { }
> };
FWIW, a similar patch earlier this week drew the following from Bob Copeand:
"... but can you by chance put a contact address in the comment? I've been
collecting them in case we one day figure out a better way to do this so it's
easy to find the people to retest."
Would you mind complying with his request? Or have I mistakend his applicability?
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Fri, Nov 6, 2009 at 11:09 AM, John W. Linville
<[email protected]> wrote:
> "... but can you by chance put a contact address in the comment? ?I've been
> collecting them in case we one day figure out a better way to do this so it's
> easy to find the people to retest."
>
> Would you mind complying with his request? ?Or have I mistakend his applicability?
It's still applicable in the general case, but I think the new patch
is for the same HW as the earlier one posted (Carlo can confirm)
so we should be good already.
--
Bob Copeland %% http://www.bobcopeland.com
On Fri, Nov 6, 2009 at 8:00 AM, Carlo Parata <[email protected]> wrote:
> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
> compatible devices in ath5k driver now includes the hardware present in this
> computer, as well as the led pin and polarity.
>
> --- ../led.c ? ?2009-11-06 06:16:39.000000000 +0100
> +++ ./drivers/net/wireless/ath/ath5k/led.c ? ? ?2009-11-06 12:37:44.000000000 +0100
> @@ -73,6 +73,8 @@
> ? ? ? ?{ ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
> ? ? ? ?/* IBM-specific AR5212 (all others) */
> ? ? ? ?{ PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
> + ? ? ? ?/* Acer Aspire One D250 AR5007EG */
> + ? ? ? { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
No, this should be based on the subdevice instead
(there are lots of ath:001c with different LED settings).
Also, please add your email to the appropriate stanza.
--
Bob Copeland %% http://www.bobcopeland.com
On 11/06/2009 09:16 AM, Bob Copeland wrote:
> On Fri, Nov 6, 2009 at 8:00 AM, Carlo Parata <[email protected]> wrote:
>> With this patch, a Acer Aspire One D250 can turn on the wifi led. The array of
>> compatible devices in ath5k driver now includes the hardware present in this
>> computer, as well as the led pin and polarity.
>>
>> --- ../led.c 2009-11-06 06:16:39.000000000 +0100
>> +++ ./drivers/net/wireless/ath/ath5k/led.c 2009-11-06 12:37:44.000000000 +0100
>> @@ -73,6 +73,8 @@
>> { ATH_SDEVICE(PCI_VENDOR_ID_HP, 0x0137b), ATH_LED(3, 1) },
>> /* IBM-specific AR5212 (all others) */
>> { PCI_VDEVICE(ATHEROS, PCI_DEVICE_ID_ATHEROS_AR5212_IBM), ATH_LED(0, 0) },
>> + /* Acer Aspire One D250 AR5007EG */
>> + { PCI_VDEVICE(ATHEROS, 0x001c), ATH_LED(3, 1) },
>
> No, this should be based on the subdevice instead
> (there are lots of ath:001c with different LED settings).
>
> Also, please add your email to the appropriate stanza.
It is more than just your E-mail address. Please see
Documents/SubmittingPatches.