2018-04-17 09:27:37

by Rakesh Pillai

[permalink] [raw]
Subject: Re: ath10k: Enable hw checksum for wcn3990

Hi Kalle,

The ath10k-check warning has been corrected and I have sent the v2 for
the same.

Thanks,
Rakesh Pillai.

On 2018-04-16 18:46, Kalle Valo wrote:
> Rakesh Pillai <[email protected]> wrote:
>
>> By default ath10k driver enables the support for HW_CHECKSUM
>> (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not
>> enabled
>> in the wcn3990 firmware the checksum is incorrect in the TCP/UDP
>> packets
>> and all patckets are dropped. But due note that wcn3990 support in
>> ath10k is still incomplete so this isn't a critical fix (yet).
>>
>> Enable hw checksum calculations in wcn3990 hardware by
>> setting the proper flags in msdu descriptor tso flags.
>>
>> Signed-off-by: Rakesh Pillai <[email protected]>
>> Signed-off-by: Kalle Valo <[email protected]>
>
> Introduces a new sparse warning:
>
> potku:~/ath10k/src/ath$ ath10k-check
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid
> assignment: |=
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: left side has
> type restricted __le32
> drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: right side has
> type unsigned long
>
> Patch set to Changes Requested.