2022-03-13 22:23:55

by Larry Finger

[permalink] [raw]
Subject: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6

The rtl8821ce with RFE Type 6 behaves the same as ones with RFE Type 0.

This change has been tested in the repo at git://GitHub.com/lwfinger/rtw88.git.
It fixes commit 769a29ce2af4 ("rtw88: 8821c: add basic functions").

Fixes: 769a29ce2af4 ("rtw88: 8821c: add basic functions").
Signed-off-by: Ping-Ke Shih <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
Cc: [email protected] # 5.9+
---
Kalle,

This patch file was prepared a couple of months ago, but apparently not submitted
then. It should be applied as soon as possible.

Larry
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index db078df63f85..b1f4afb50830 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1514,6 +1514,7 @@ static const struct rtw_rfe_def rtw8821c_rfe_defs[] = {
[0] = RTW_DEF_RFE(8821c, 0, 0),
[2] = RTW_DEF_RFE_EXT(8821c, 0, 0, 2),
[4] = RTW_DEF_RFE_EXT(8821c, 0, 0, 2),
+ [6] = RTW_DEF_RFE(8821c, 0, 0),
};

static struct rtw_hw_reg rtw8821c_dig[] = {
--
2.35.1


2022-03-14 06:27:01

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6


> -----Original Message-----
> From: Larry Finger <[email protected]>
> Sent: Monday, March 14, 2022 12:44 AM
> To: [email protected]
> Cc: [email protected]; Larry Finger <[email protected]>; Pkshih <[email protected]>;
> [email protected]
> Subject: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6
>
> The rtl8821ce with RFE Type 6 behaves the same as ones with RFE Type 0.
>
> This change has been tested in the repo at git://GitHub.com/lwfinger/rtw88.git.
> It fixes commit 769a29ce2af4 ("rtw88: 8821c: add basic functions").
>
> Fixes: 769a29ce2af4 ("rtw88: 8821c: add basic functions").
> Signed-off-by: Ping-Ke Shih <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: [email protected] # 5.9+
> ---
> Kalle,
>
> This patch file was prepared a couple of months ago, but apparently not submitted
> then. It should be applied as soon as possible.
>
> Larry

Hi Larry,

This patch has been merged [1]. The git link of wireless driver next has been
changed [2]. That may be the reason you can't find the patch.

[1] https://lore.kernel.org/all/[email protected]/
[2] git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git

Ping-Ke

2022-03-14 12:22:56

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6

Pkshih <[email protected]> writes:

>> -----Original Message-----
>> From: Larry Finger <[email protected]>
>> Sent: Monday, March 14, 2022 12:44 AM
>> To: [email protected]
>> Cc: [email protected]; Larry Finger
>> <[email protected]>; Pkshih <[email protected]>;
>> [email protected]
>> Subject: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6
>>
>> The rtl8821ce with RFE Type 6 behaves the same as ones with RFE Type 0.
>>
>> This change has been tested in the repo at git://GitHub.com/lwfinger/rtw88.git.
>> It fixes commit 769a29ce2af4 ("rtw88: 8821c: add basic functions").
>>
>> Fixes: 769a29ce2af4 ("rtw88: 8821c: add basic functions").
>> Signed-off-by: Ping-Ke Shih <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>> Cc: [email protected] # 5.9+
>> ---
>> Kalle,
>>
>> This patch file was prepared a couple of months ago, but apparently not submitted
>> then. It should be applied as soon as possible.
>>
>> Larry
>
> Hi Larry,
>
> This patch has been merged [1]. The git link of wireless driver next has been
> changed [2]. That may be the reason you can't find the patch.
>
> [1]
> https://lore.kernel.org/all/[email protected]/
> [2] git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git

So the commit id is:

e109e3617e5d rtw88: rtw8821c: enable rfe 6 devices

And the commit should be in v5.18-rc1, which is most likely released in
three weeks.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-03-14 20:29:03

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6

On 3/13/22 19:21, Pkshih wrote:
>
>> -----Original Message-----
>> From: Larry Finger <[email protected]>
>> Sent: Monday, March 14, 2022 12:44 AM
>> To: [email protected]
>> Cc: [email protected]; Larry Finger <[email protected]>; Pkshih <[email protected]>;
>> [email protected]
>> Subject: [PATCH] rtw88: Fix missing support for Realtek 8821CE RFE Type 6
>>
>> The rtl8821ce with RFE Type 6 behaves the same as ones with RFE Type 0.
>>
>> This change has been tested in the repo at git://GitHub.com/lwfinger/rtw88.git.
>> It fixes commit 769a29ce2af4 ("rtw88: 8821c: add basic functions").
>>
>> Fixes: 769a29ce2af4 ("rtw88: 8821c: add basic functions").
>> Signed-off-by: Ping-Ke Shih <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>> Cc: [email protected] # 5.9+
>> ---
>> Kalle,
>>
>> This patch file was prepared a couple of months ago, but apparently not submitted
>> then. It should be applied as soon as possible.
>>
>> Larry
>
> Hi Larry,
>
> This patch has been merged [1]. The git link of wireless driver next has been
> changed [2]. That may be the reason you can't find the patch.
>
> [1] https://lore.kernel.org/all/[email protected]/
> [2] git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git

Ping-Ke,

Thanks for the heads-up. I have re-cloned my repo.

@Kalle: Ignore the noise.

Larry