2021-12-02 07:22:13

by Ian Lin

[permalink] [raw]
Subject: [PATCH v2] brcmfmac: add CYW43570 PCIE device


From: Soontak Lee <[email protected]>

CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
It is BT/WIFI combo.

Signed-off-by: Soontak Lee <[email protected]>
Signed-off-by: Chi-Hsien Lin <[email protected]>
Signed-off-by: Ian Lin <[email protected]>
---
Changes in v2:
  - Add missing Signed-off-by in commit message

  drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c       | 1 +
  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
  2 files changed, 2 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 8b149996fc00..ceeb1f10752a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -2106,6 +2106,7 @@ static const struct pci_device_id
brcmf_pcie_devid_table[] = {
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
+    BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_RAW_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4358_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_4359_DEVICE_ID),
      BRCMF_PCIE_DEVICE(BRCM_PCIE_43602_DEVICE_ID),
diff --git
a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
index 9d81320164ce..3bbe2388ec54 100644
--- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
+++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
@@ -71,6 +71,7 @@
  #define BRCM_PCIE_4356_DEVICE_ID    0x43ec
  #define BRCM_PCIE_43567_DEVICE_ID    0x43d3
  #define BRCM_PCIE_43570_DEVICE_ID    0x43d9
+#define BRCM_PCIE_43570_RAW_DEVICE_ID    0xaa31
  #define BRCM_PCIE_4358_DEVICE_ID    0x43e9
  #define BRCM_PCIE_4359_DEVICE_ID    0x43ef
  #define BRCM_PCIE_43602_DEVICE_ID    0x43ba
--
2.25.0


2021-12-15 14:23:56

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] brcmfmac: add CYW43570 PCIE device

"Lin Ian (CSSITB CSS ICW SW WFS / EE)" <[email protected]> wrote:

> From: Soontak Lee <[email protected]>
>
> CYW43570 is a 3-antenna, 2x2 MIMO,802.11a/b/g/n/ac, PCIe 3.0 for WLAN.
> It is BT/WIFI combo.
>
> Signed-off-by: Soontak Lee <[email protected]>
> Signed-off-by: Chi-Hsien Lin <[email protected]>
> Signed-off-by: Ian Lin <[email protected]>

The indentation looks wrong and also the patch is corrupted. It looks like you
used Mozilla to submit the patch so it's not surprising there are problems,
see the wiki below for more information how to submit patches using git
send-email.

error: corrupt patch at line 19

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches