2024-02-28 12:55:10

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH v2] wifi: brcm80211: handle pmk_op allocation failure

On 2/28/2024 7:34 AM, Duoming Zhou wrote:
> The kzalloc() in brcmf_pmksa_v3_op() will return null if the
> physical memory has run out. As a result, if we dereference
> the null value, the null pointer dereference bug will happen.
>
> Return -ENOMEM from brcmf_pmksa_v3_op() if kzalloc() fails
> for pmk_op.
>
> Fixes: a96202acaea4 ("wifi: brcmfmac: cfg80211: Add support for PMKID_V3 operations")

Thanks!

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Duoming Zhou <[email protected]>
> ---
> Changes in v2:
> - Drop the new label and just return -ENOMEM.
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +++
> 1 file changed, 3 insertions(+)


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature