2024-04-16 10:50:50

by Bitterblue Smith

Subject: [PATCH v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU

Software control (on/off) and hardware control (automatic blinking)
tested with EDUP EP-N8568.

Signed-off-by: Bitterblue Smith <[email protected]>
---
v2:
- More information in the commit message.
---
.../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
index 9640c841d20a..c677a47ed46d 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c
@@ -1701,6 +1701,28 @@ static s8 rtl8723b_cck_rssi(struct rtl8xxxu_priv *priv, struct rtl8723au_phy_sta
return rx_pwr_all;
}

+static int rtl8723bu_led_brightness_set(struct led_classdev *led_cdev,
+ enum led_brightness brightness)
+{
+ struct rtl8xxxu_priv *priv = container_of(led_cdev,
+ struct rtl8xxxu_priv,
+ led_cdev);
+ u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+ ledcfg &= LEDCFG2_DPDT_SELECT;
+
+ if (brightness == LED_OFF) {
+ ledcfg |= LEDCFG2_SW_LED_CONTROL | LEDCFG2_SW_LED_DISABLE;
+ } else if (brightness == LED_ON) {
+ ledcfg |= LEDCFG2_SW_LED_CONTROL;
+ } else if (brightness == RTL8XXXU_HW_LED_CONTROL) {
+ ledcfg |= LEDCFG2_HW_LED_CONTROL | LEDCFG2_HW_LED_ENABLE;
+ }
+
+ rtl8xxxu_write8(priv, REG_LEDCFG2, ledcfg);
+
+ return 0;
+}
+
struct rtl8xxxu_fileops rtl8723bu_fops = {
.identify_chip = rtl8723bu_identify_chip,
.parse_efuse = rtl8723bu_parse_efuse,
@@ -1731,6 +1753,7 @@ struct rtl8xxxu_fileops rtl8723bu_fops = {
.fill_txdesc = rtl8xxxu_fill_txdesc_v2,
.set_crystal_cap = rtl8723a_set_crystal_cap,
.cck_rssi = rtl8723b_cck_rssi,
+ .led_classdev_brightness_set = rtl8723bu_led_brightness_set,
.writeN_block_size = 1024,
.tx_desc_size = sizeof(struct rtl8xxxu_txdesc40),
.rx_desc_size = sizeof(struct rtl8xxxu_rxdesc24),
--
2.44.0

2024-04-19 02:04:05

by Ping-Ke Shih

Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU

Bitterblue Smith <[email protected]> wrote:

> Software control (on/off) and hardware control (automatic blinking)
> tested with EDUP EP-N8568.
>
> Signed-off-by: Bitterblue Smith <[email protected]>

Checkpatch warns:

WARNING: Missing a blank line after declarations
#28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711:
+ u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+ ledcfg &= LEDCFG2_DPDT_SELECT;

WARNING: braces {} are not necessary for any arm of this statement
#30: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1713:
+ if (brightness == LED_OFF) {
[...]
+ } else if (brightness == LED_ON) {
[...]
+ } else if (brightness == RTL8XXXU_HW_LED_CONTROL) {
[...]

Set patchset state to Changes Requested

[v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU

---
https://github.com/pkshih/rtw.git