2022-12-02 19:57:46

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH v2] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware()

On 12/2/2022 6:35 AM, Wang Yufen wrote:
> Fix to return a negative error code instead of 0 when
> brcmf_chip_set_active() fails. In addition, change the return
> value for brcmf_pcie_exit_download_state() to keep consistent.
>
> Fixes: d380ebc9b6fb ("brcmfmac: rename chip download functions")
Reviewed-by: Arend van Spriel <[email protected]>
> Signed-off-by: Wang Yufen <[email protected]>
> ---
> v2: change the error code from EINVAL to EIO, as Arend suggessted

Thanks.

> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature