2008-05-10 11:30:14

by Andrea Merello

Subject: PATCH Rtl8180 ch14 [1/3]

Rtl8180: fix wrong parameter in RF code funcion invokation for philips radio

The sa2400 RF code needs to invoke sa2400_write_phy_antenna every time the
channel is being switch.

This should be done passing the channel number to that function.
Incorrectly we were passing the same value that is written on the
channel RF register.
This may cause problems when operating on ch 14.

This patch fixes it.

Thanks to Alessandro Di Marco who found this issue!


signed-off-by: Andrea Merello <[email protected]>
---

--- a/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02
14:48:52.000000000 +0100
+++ b/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02
14:49:44.000000000 +0100
@@ -85,7 +85,7 @@ static void sa2400_rf_set_channel(struct

write_sa2400(dev, 7, txpw);

- sa2400_write_phy_antenna(dev, chan);
+ sa2400_write_phy_antenna(dev, conf->channel);

write_sa2400(dev, 0, chan);
write_sa2400(dev, 1, 0xbb50);

2008-05-14 20:20:43

by John W. Linville

Subject: Re: [PATCH] Rtl8180 sa2400 ch14

On Sat, May 10, 2008 at 01:30:12PM +0200, Andrea Merello wrote:
> Rtl8180: fix wrong parameter in RF code funcion invokation for philip=
s radio
>=20
> The sa2400 RF code needs to invoke sa2400_write_phy_antenna every tim=
e the
> channel is being switch.
>=20
> This should be done passing the channel number to that function.
> Incorrectly we were passing the same value that is written on the
> channel RF register.
> This may cause problems when operating on ch 14.
>=20
> This patch fixes it.
>=20
> Thanks to Alessandro Di Marco who found this issue!
>=20
>=20
> signed-off-by: Andrea Merello <[email protected]>
> ---
>=20
> --- a/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02
> 14:48:52.000000000 +0100
> +++ b/drivers/net/wireless/rtl8180_sa2400.c 2008-02-02
> 14:49:44.000000000 +0100
> @@ -85,7 +85,7 @@ static void sa2400_rf_set_channel(struct
>=20
> write_sa2400(dev, 7, txpw);
>=20
> - sa2400_write_phy_antenna(dev, chan);
> + sa2400_write_phy_antenna(dev, conf->channel);
>=20
> write_sa2400(dev, 0, chan);
> write_sa2400(dev, 1, 0xbb50);

CC [M] drivers/net/wireless/rtl8180_sa2400.o
drivers/net/wireless/rtl8180_sa2400.c: In function =E2=80=98sa2400_rf_s=
et_channel=E2=80=99:
drivers/net/wireless/rtl8180_sa2400.c:89: warning: passing argument 2 o=
f =E2=80=98sa2400_write_phy_antenna=E2=80=99 makes integer from pointer=
without a cast

Also, the patch is whitespace-damaged and it should be "Signed-off-by"
(note the capital letter) if you don't mind. :-)

Thanks,

John
--=20
John W. Linville
[email protected]