2017-06-27 22:07:58

by Peter Oh

[permalink] [raw]
Subject: [PATCH] ieee80211: update public action codes

From: Peter Oh <[email protected]>

Update Public Action field values as updated in IEEE Std 802.11-2016,
so that modules/drivers can refer it.

Signed-off-by: Peter Oh <[email protected]>
---
include/linux/ieee80211.h | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 6903335..91a1145 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -2113,10 +2113,43 @@ enum ieee80211_key_len {

#define PMK_MAX_LEN 48

-/* Public action codes */
+/* Public action codes (IEEE Std 802.11-2016, 9.6.8.1, Table 9-307) */
enum ieee80211_pub_actioncode {
+ WLAN_PUB_ACTION_20_40_BSS_COEX = 0,
+ WLAN_PUB_ACTION_DSE_ENABLEMENT = 1,
+ WLAN_PUB_ACTION_DSE_DEENABLEMENT = 2,
+ WLAN_PUB_ACTION_DSE_REG_LOC_ANN = 3,
WLAN_PUB_ACTION_EXT_CHANSW_ANN = 4,
+ WLAN_PUB_ACTION_DSE_MSMT_REQ = 5,
+ WLAN_PUB_ACTION_DSE_MSMT_RESP = 6,
+ WLAN_PUB_ACTION_MSMT_PILOT = 7,
+ WLAN_PUB_ACTION_DSE_PC = 8,
+ WLAN_PUB_ACTION_VENDOR_SPECIFIC = 9,
+ WLAN_PUB_ACTION_GAS_INITIAL_REQ = 10,
+ WLAN_PUB_ACTION_GAS_INITIAL_RESP = 11,
+ WLAN_PUB_ACTION_GAS_COMEBACK_REQ = 12,
+ WLAN_PUB_ACTION_GAS_COMEBACK_RESP = 13,
WLAN_PUB_ACTION_TDLS_DISCOVER_RES = 14,
+ WLAN_PUB_ACTION_LOC_TRACK_NOTI = 15,
+ WLAN_PUB_ACTION_QAB_REQUEST_FRAME = 16,
+ WLAN_PUB_ACTION_QAB_RESPONSE_FRAME = 17,
+ WLAN_PUB_ACTION_QMF_POLICY = 18,
+ WLAN_PUB_ACTION_QMF_POLICY_CHANGE = 19,
+ WLAN_PUB_ACTION_QLOAD_REQUEST = 20,
+ WLAN_PUB_ACTION_QLOAD_REPORT = 21,
+ WLAN_PUB_ACTION_HCCA_TXOP_ADVERT = 22,
+ WLAN_PUB_ACTION_HCCA_TXOP_RESPONSE = 23,
+ WLAN_PUB_ACTION_PUBLIC_KEY = 24,
+ WLAN_PUB_ACTION_CHANNEL_AVAIL_QUERY = 25,
+ WLAN_PUB_ACTION_CHANNEL_SCHEDULE_MGMT = 26,
+ WLAN_PUB_ACTION_CONTACT_VERI_SIGNAL = 27,
+ WLAN_PUB_ACTION_GDD_ENABLEMENT_REQ = 28,
+ WLAN_PUB_ACTION_GDD_ENABLEMENT_RESP = 29,
+ WLAN_PUB_ACTION_NETWORK_CHANNEL_CONTROL = 30,
+ WLAN_PUB_ACTION_WHITE_SPACE_MAP_ANN = 31,
+ WLAN_PUB_ACTION_FTM_REQUEST = 32,
+ WLAN_PUB_ACTION_FTM = 33,
+ WLAN_PUB_ACTION_FILS_DISCOVERY = 34,
};

/* TDLS action codes */
--
2.7.4


2017-06-28 20:24:19

by Peter Oh

[permalink] [raw]
Subject: Re: [PATCH] ieee80211: update public action codes



On 06/28/2017 01:16 PM, Arend van Spriel wrote:
> On 28-06-17 00:07, [email protected] wrote:
>> From: Peter Oh <[email protected]>
>>
>> Update Public Action field values as updated in IEEE Std 802.11-2016,
>> so that modules/drivers can refer it.
> Hi Peter,
>
> I am pretty sure there are a lot of other definitions in the 802.11 spec
> that are not in a linux header file. So are you planning on submitting
> driver patches using the added definitions. Stuff is mostly added as needed.
I have extra patches that uses the new values, but doubt if it's fit to
be upstream.
> Regards,
> Arend

2017-06-29 13:21:05

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] ieee80211: update public action codes

On Tue, 2017-06-27 at 15:07 -0700, [email protected] wrote:
> From: Peter Oh <[email protected]>
>
> Update Public Action field values as updated in IEEE Std 802.11-2016,
> so that modules/drivers can refer it.
>
> Signed-off-by: Peter Oh <[email protected]>

Reviewed-by: Johannes Berg <[email protected]>

Kalle, it looks like this is the only patch I'm willing to pick up
before I go, so I figured you can just throw it into your tree, and
will assign it to you in patchwork.

johannes

2017-06-30 05:52:58

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ieee80211: update public action codes

Johannes Berg <[email protected]> writes:

> On Tue, 2017-06-27 at 15:07 -0700, [email protected] wrote:
>> From: Peter Oh <[email protected]>
>>
>> Update Public Action field values as updated in IEEE Std 802.11-2016,
>> so that modules/drivers can refer it.
>>
>> Signed-off-by: Peter Oh <[email protected]>
>
> Reviewed-by: Johannes Berg <[email protected]>
>
> Kalle, it looks like this is the only patch I'm willing to pick up
> before I go, so I figured you can just throw it into your tree, and
> will assign it to you in patchwork.

Sure, I'll take it. Enjoy your sabbatical!

--
Kalle Valo

2017-06-28 20:16:36

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH] ieee80211: update public action codes

On 28-06-17 00:07, [email protected] wrote:
> From: Peter Oh <[email protected]>
>
> Update Public Action field values as updated in IEEE Std 802.11-2016,
> so that modules/drivers can refer it.

Hi Peter,

I am pretty sure there are a lot of other definitions in the 802.11 spec
that are not in a linux header file. So are you planning on submitting
driver patches using the added definitions. Stuff is mostly added as needed.

Regards,
Arend

> Signed-off-by: Peter Oh <[email protected]>
> ---
> include/linux/ieee80211.h | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)

2017-06-29 07:57:46

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] ieee80211: update public action codes

On Wed, 2017-06-28 at 13:24 -0700, Peter Oh wrote:
>
> On 06/28/2017 01:16 PM, Arend van Spriel wrote:
> > On 28-06-17 00:07, [email protected] wrote:
> > > From: Peter Oh <[email protected]>
> > >
> > > Update Public Action field values as updated in IEEE Std 802.11-
> > > 2016,
> > > so that modules/drivers can refer it.
> >
> > Hi Peter,
> >
> > I am pretty sure there are a lot of other definitions in the 802.11
> > spec
> > that are not in a linux header file. So are you planning on
> > submitting
> > driver patches using the added definitions. Stuff is mostly added
> > as needed.

I think that's mostly laziness though :-) I'm perfectly happy to have
all these values in even if we don't use them now - they're not going
to change by not using.

> I have extra patches that uses the new values, but doubt if it's fit
> to be upstream.

I guess you can try :)

johannes

2017-06-30 06:50:46

by Kalle Valo

[permalink] [raw]
Subject: Re: ieee80211: update public action codes

Peter Oh <[email protected]> wrote:

> From: Peter Oh <[email protected]>
>
> Update Public Action field values as updated in IEEE Std 802.11-2016,
> so that modules/drivers can refer it.
>
> Signed-off-by: Peter Oh <[email protected]>
> Reviewed-by: Johannes Berg <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

3cb57df37bf3 ieee80211: update public action codes

--
https://patchwork.kernel.org/patch/9813187/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches