2022-05-16 15:39:31

by Maxime Bizon

[permalink] [raw]
Subject: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz

Because of this missing switch case, 160Mhz transmit was reported as
20Mhz, leading to wrong airtime calculation and AQL limiting max
throughput.

Signed-off-by: Maxime Bizon <[email protected]>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 771252dd6d4e..e8727c0b0171 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -3884,6 +3884,10 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar,
arsta->tx_info.status.rates[0].flags |=
IEEE80211_TX_RC_80_MHZ_WIDTH;
break;
+ case RATE_INFO_BW_160:
+ arsta->tx_info.status.rates[0].flags |=
+ IEEE80211_TX_RC_160_MHZ_WIDTH;
+ break;
}

if (peer_stats->succ_pkts) {
--
2.17.1




2022-05-16 20:07:32

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz

Maxime Bizon <[email protected]> writes:

> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Signed-off-by: Maxime Bizon <[email protected]>

On what ath10k hardware and afirmware version did you test this? I can
add that to the commit log.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-05-16 20:07:44

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz

Maxime Bizon <[email protected]> writes:

> On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:
>
>> On what ath10k hardware and afirmware version did you test this? I
>> can add that to the commit log.
>>
>
> QCA9984
> 10.4-3.10-00047

Thanks, I added that in the pending branch.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-05-17 03:30:17

by Maxime Bizon

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz


On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote:

Hello Kalle,

> On what ath10k hardware and afirmware version did you test this? I
> can add that to the commit log.
>

QCA9984
10.4-3.10-00047

--
Maxime




2022-05-23 06:00:50

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: fix misreported tx bandwidth for 160Mhz

Maxime Bizon <[email protected]> wrote:

> Because of this missing switch case, 160Mhz transmit was reported as
> 20Mhz, leading to wrong airtime calculation and AQL limiting max
> throughput.
>
> Tested-on: QCA9984 hw2.0 PCI 10.4-3.10-00047
>
> Signed-off-by: Maxime Bizon <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

75a7062e533e ath10k: fix misreported tx bandwidth for 160Mhz

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches