2017-12-29 21:18:24

by SF Markus Elfring

Subject: [PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

From: Markus Elfring <[email protected]>
Date: Fri, 29 Dec 2017 22:11:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
index a2c1ca5c76d1..6598cefdbe71 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
@@ -1244,10 +1244,8 @@ int rt2x00queue_allocate(struct rt2x00_dev *rt2x00dev)
rt2x00dev->data_queues = 2 + rt2x00dev->ops->tx_queues + req_atim;

queue = kcalloc(rt2x00dev->data_queues, sizeof(*queue), GFP_KERNEL);
- if (!queue) {
- rt2x00_err(rt2x00dev, "Queue allocation failed\n");
+ if (!queue)
return -ENOMEM;
- }

/*
* Initialize pointers
--
2.15.1

2018-01-03 12:26:30

by Stanislaw Gruszka

Subject: Re: [PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

On Fri, Dec 29, 2017 at 10:18:14PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Fri, 29 Dec 2017 22:11:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Acked-by: Stanislaw Gruszka <[email protected]>

2018-01-08 15:46:55

by Kalle Valo

Subject: Re: rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

SF Markus Elfring <[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Fri, 29 Dec 2017 22:11:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> Acked-by: Stanislaw Gruszka <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

cd7c0cdab7ff rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

--
https://patchwork.kernel.org/patch/10137399/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches