2023-03-22 09:11:20

by Dan Carpenter

Subject: [PATCH] wifi: legacy: rndis_wlan: clean up a type issue

The rndis_bss_info_update() returns type bool. Change the NULL
returns to false.

Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/net/wireless/legacy/rndis_wlan.c | 6 +++++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/legacy/rndis_wlan.c b/drivers/net/wireless/legacy/rndis_wlan.c
index bf72e5fd39cf..49e846a0fafd 100644
--- a/drivers/net/wireless/legacy/rndis_wlan.c
+++ b/drivers/net/wireless/legacy/rndis_wlan.c
@@ -1972,7 +1972,7 @@ static bool rndis_bss_info_update(struct usbnet *usbdev,

if (bssid_len < sizeof(struct ndis_80211_bssid_ex) +
sizeof(struct ndis_80211_fixed_ies))
- return NULL;
+ return false;

fixed = (struct ndis_80211_fixed_ies *)bssid->ies;

@@ -1981,13 +1981,13 @@ static bool rndis_bss_info_update(struct usbnet *usbdev,
(int)le32_to_cpu(bssid->ie_length));
ie_len -= sizeof(struct ndis_80211_fixed_ies);
if (ie_len < 0)
- return NULL;
+ return false;

/* extract data for cfg80211_inform_bss */
channel = ieee80211_get_channel(priv->wdev.wiphy,
KHZ_TO_MHZ(le32_to_cpu(bssid->config.ds_config)));
if (!channel)
- return NULL;
+ return false;

signal = level_to_qual(le32_to_cpu(bssid->rssi));
timestamp = le64_to_cpu(*(__le64 *)fixed->timestamp);

2023-03-31 14:50:36

by Kalle Valo

Subject: Re: wifi: rndis_wlan: clean up a type issue

Dan Carpenter <[email protected]> wrote:

> The rndis_bss_info_update() returns type bool. Change the NULL
> returns to false.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Patch applied to wireless-next.git, thanks.

703f15b6dce1 wifi: rndis_wlan: clean up a type issue

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches