2018-08-31 20:24:08

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] b43: Fix regression in kernel 4.18

On 08/31/2018 10:38 AM, Kalle Valo wrote:
> Larry Finger <[email protected]> wrote:
>
>> In commit 66cffd6daab7 ("b43: fix transmit failure when VT is switched"),
>> a condition is noted where the network controller needs to be reset. Note
>> that this situation happens when running the open-source firmware
>> (http://netweb.ing.unibs.it/~openfwwf/), plus a number of other special
>> conditions.
>>
>> for a different card model, it is reported that this change breaks
>> operation running the proprietary firmware
>> (https://marc.info/?l=linux-wireless&m=153504546924558&w=2). Rather
>> than reverting the previous patch, the code is tweaked to avoid the
>> reset unless the open-source firmware is being used.
>>
>> Fixes: 66cffd6daab7 ("b43: fix transmit failure when VT is switched")
>> Cc: Stable <[email protected]> # 4.18+
>> Cc: Taketo Kabe <[email protected]>
>> Reported-and-tested-by: D. Prabhu <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>
> I'll change the title to something more descriptive:
>
> b43: fix DMA error related regression with proprietary firmware
>
> Does that make sense?

Yes, that is fine.

Larry