2021-11-18 16:46:00

by Ben Greear

[permalink] [raw]
Subject: [PATCH 4/8] mt76: mt7915: add note about TXSFM 0x2

From: Ben Greear <[email protected]>

This format needs a special command to enable, and is not enabled
by default.

Signed-off-by: Ben Greear <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
index 7a2c740d1464..b66e740832e4 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
@@ -348,6 +348,9 @@ struct mt7915_tx_free {

#define MT_TXS4_TIMESTAMP GENMASK(31, 0)

+/* The F0 variables are for TXSFM 0x0 and 0x1. The F1 variables
+ * are for TXSFM 0x2 aka PPDU format.
+ */
#define MT_TXS5_F0_FINAL_MPDU BIT(31)
#define MT_TXS5_F0_QOS BIT(30)
#define MT_TXS5_F0_TX_COUNT GENMASK(29, 25)
--
2.20.1



2021-11-18 17:03:00

by Ryder Lee

[permalink] [raw]
Subject: Re: [PATCH 4/8] mt76: mt7915: add note about TXSFM 0x2

On Thu, 2021-11-18 at 08:45 -0800, [email protected] wrote:
> From: Ben Greear <[email protected]>
>
> This format needs a special command to enable, and is not enabled
> by default.
>
> Signed-off-by: Ben Greear <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
> b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
> index 7a2c740d1464..b66e740832e4 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
> @@ -348,6 +348,9 @@ struct mt7915_tx_free {
>
> #define MT_TXS4_TIMESTAMP GENMASK(31, 0)
>
> +/* The F0 variables are for TXSFM 0x0 and 0x1. The F1 variables
> + * are for TXSFM 0x2 aka PPDU format.
> + */
> #define MT_TXS5_F0_FINAL_MPDU BIT(31)
> #define MT_TXS5_F0_QOS BIT(30)
> #define MT_TXS5_F0_TX_COUNT GENMASK(29, 25)

Now that we don't need it why should it needs a special command.

Ryder


2021-11-18 17:06:26

by Ben Greear

[permalink] [raw]
Subject: Re: [PATCH 4/8] mt76: mt7915: add note about TXSFM 0x2

On 11/18/21 9:02 AM, Ryder Lee wrote:
> On Thu, 2021-11-18 at 08:45 -0800, [email protected] wrote:
>> From: Ben Greear <[email protected]>
>>
>> This format needs a special command to enable, and is not enabled
>> by default.
>>
>> Signed-off-by: Ben Greear <[email protected]>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> index 7a2c740d1464..b66e740832e4 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> @@ -348,6 +348,9 @@ struct mt7915_tx_free {
>>
>> #define MT_TXS4_TIMESTAMP GENMASK(31, 0)
>>
>> +/* The F0 variables are for TXSFM 0x0 and 0x1. The F1 variables
>> + * are for TXSFM 0x2 aka PPDU format.
>> + */
>> #define MT_TXS5_F0_FINAL_MPDU BIT(31)
>> #define MT_TXS5_F0_QOS BIT(30)
>> #define MT_TXS5_F0_TX_COUNT GENMASK(29, 25)
>
> Now that we don't need it why should it needs a special command.

It can be hard for a new developer to the driver to understand
the firmware API, so a comment could save the next person to look
at this some time and trouble.

Thanks,
Ben

>
> Ryder
>


--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com