2017-11-28 10:07:45

by Balaji Pothunoori

[permalink] [raw]
Subject: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

From: Balaji Pothunoori <[email protected]>

Data packets are not sent by STA in case of STA joined to
non QOS AP (WMM disabled AP). This is happening because of STA
is sending data packets to firmware from host with qos enabled
along with non qos queue value(TID = 16).
Due to qos enabled, firmware is discarding the packet.

This patch fixes this issue by updating the qos based on station
WME capability field if WMM is disabled in AP.

This patch is required by 10.4 family chipsets like
QCA4019/QCA9888/QCA9884/QCA99X0.
Firmware Versoin : 10.4-3.5.1-00018.

For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch
has no effect.

Signed-off-by: Balaji Pothunoori <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 0a947ee..2616b99 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -2563,7 +2563,7 @@ static void ath10k_peer_assoc_h_qos(struct ath10k *ar,
}
break;
case WMI_VDEV_TYPE_STA:
- if (vif->bss_conf.qos)
+ if (sta->wme)
arg->peer_flags |= arvif->ar->wmi.peer_flags->qos;
break;
case WMI_VDEV_TYPE_IBSS:
--
1.7.9.5


2017-11-30 05:24:46

by Balaji Pothunoori

[permalink] [raw]
Subject: RE: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

Pj4+PiBIaSBTZWJhc3RpYW4sDQo+Pj4+SWYgSSBhbSBub3Qgd3JvbmcgeW91IGFyZSBzZWVpbmcg
dGhlIGlzc3VlIHdpdGggV1JUMzIwMEFDTSAoTWFydmVsbCA4OFc4OTY0KSBhcyBjbGllbnQgKyBR
Q0E5OTg0IChGVyA6IDEwLjQtMy41LjMtMDAwMzgpIGFzIEFQIHdpdGggYmVsb3cgY2hhbmdlIHlv
dSBhcmUgc2VlaW5nIHRoZSBjcmFzaCB3aGlsZSBydW5uaW5nIHRyYWZmaWMgYmV0d2VlbiB0aGUg
V1JUMzIwMEFDTSArIFFDQTk5ODQgPw0KPj4+PiBEbyB5b3UgdXNlZCAgYW55IG90aGVyIGNsaWVu
dCBpbiBwbGFjZSBvZiBXUlQzMjAwQUNNID8NCj4+PiB0aGVyZSBpcyBub3QgbXVjaCAgdHJhZmZp
YyByZXF1aXJlZC4gYXMgaXQgc2VlbXMgdGhlIGZpcm13YXJlIGNyYXNoZXMgDQo+Pj4gaW1tZWRp
YXRseSBhZnRlciBhc3NvY2lhdGlvbi4gdGhlIGlzc3VlIGlzIGFsc28gbm90IHByZXNlbnQgaW4g
DQo+Pj4gMTAuNC0zLjQtMDA4Mnd3DQo+PiBTdGlsbCBteSBxdWVzdGlvbiBpcyBub3QgY2xlYXJl
ZCwgIGZpcm13YXJlIGNyYXNoIGlzIGR1ZSB0byB0aGlzIHBhdGNoID8gQWxzbyBsZXQgbWUga25v
dyBkbyB5b3Ugb2JzZXJ2ZWQgc2FtZSBiZWhhdmlvciB3aXRoIGFueSBvdGhlciBjaGlwc2V0ID8N
Cg0KPm5vLiBpdHMgdW5yZWxhdGVkIHRvIHRoaXMgcGF0Y2ggYnV0IHNpbmNlIHlvdSdyZSB3b3Jr
aW5nIGZvciBxY2EgaSB0aG91Z2h0IGl0IHdvdWxkIG1ha2Ugc2Vuc2UgdG8gdGVsbCB5b3UgdGhp
cyBzaW5jZSBzYXcgdGhhdCB5b3UncmUgdXNpbmcgYXRoMTBrIGZpcm13YXJlcyB3aGljaCBhcmVu
dCBwdWJsaXNoZWQgb2ZmaWNpYWxsIGJ1dCBiYXNlZCBvbiB0aGUNCg0KPnFjYSBmaXJtd2FyZXMg
d2hpY2ggYXJlIHB1Ymxpc2hlZCBvbiBjaGlwY29kZS4gc2luY2UgaSB3YXMgdGVzdGluZyB0aGVz
ZSBmaXJtd2FyZXMgdG9vIHNvbWUgd2Vla3MgYWdvIGkgZm91bmQgaXRzIGEgZ29vZCBpZGVhIHRv
IHRlbGwgeW91IHRoaXMNCg0KVGhhbmtzIGZvciBjb25maXJtYXRpb24gLCBMZXQgdXMga25vdyBm
cm9tIHdoZXJlIHlvdSBoYXZlIHByb2N1cmVkIGF0aDEwayBmaXJtd2FyZSA6IDEwLjQtMy41LjMt
MDAwMzggPyBEaWQgeW91IGFsc28gc2VlbiB0aGUgaXNzdWUgb24gbGF0ZXN0IGZpcm13YXJlIHZl
cnNpb24/DQoNCj4+DQo+PiAgIA0KPj4gUmVnYXJkcywNCj4+IEJhbGFqaS4NCj4NCj4+IFNlYmFz
dGlhbg0KPg0KPj4+IFJlZ2FyZHMsDQo+Pj4gQmFsYWppLg0KDQotLS0tLU9yaWdpbmFsIE1lc3Nh
Z2UtLS0tLQ0KRnJvbTogU2ViYXN0aWFuIEdvdHRzY2hhbGwgW21haWx0bzpzLmdvdHRzY2hhbGxA
ZGQtd3J0LmNvbV0gDQpTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDI5LCAyMDE3IDc6MDggUE0N
ClRvOiBCYWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9AcXRpLnF1YWxjb21tLmNvbT47IGF0aDEw
a0BsaXN0cy5pbmZyYWRlYWQub3JnDQpDYzogbGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3Jn
DQpTdWJqZWN0OiBSZTogW1BBVENIXSBhdGgxMGs6IGhhbmRsaW5nIHFvcyBhdCBTVEEgc2lkZSBi
YXNlZCBvbiBBUCBXTU0gZW5hYmxlL2Rpc2FibGUNCg0KQW0gMjkuMTEuMjAxNyB1bSAxMToxMiBz
Y2hyaWViIEJhbGFqaSBQb3RodW5vb3JpOg0KPj4+IEhpIFNlYmFzdGlhbiwNCj4+Pg0KPj4+IElm
IEkgYW0gbm90IHdyb25nIHlvdSBhcmUgc2VlaW5nIHRoZSBpc3N1ZSB3aXRoIFdSVDMyMDBBQ00g
KE1hcnZlbGwgODhXODk2NCkgYXMgY2xpZW50ICsgUUNBOTk4NCAoRlcgOiAxMC40LTMuNS4zLTAw
MDM4KSBhcyBBUCB3aXRoIGJlbG93IGNoYW5nZSB5b3UgYXJlIHNlZWluZyB0aGUgY3Jhc2ggd2hp
bGUgcnVubmluZyB0cmFmZmljIGJldHdlZW4gdGhlIFdSVDMyMDBBQ00gKyBRQ0E5OTg0ID8NCj4+
PiBEbyB5b3UgdXNlZCAgYW55IG90aGVyIGNsaWVudCBpbiBwbGFjZSBvZiBXUlQzMjAwQUNNID8N
Cj4+IHRoZXJlIGlzIG5vdCBtdWNoICB0cmFmZmljIHJlcXVpcmVkLiBhcyBpdCBzZWVtcyB0aGUg
ZmlybXdhcmUgY3Jhc2hlcyANCj4+IGltbWVkaWF0bHkgYWZ0ZXIgYXNzb2NpYXRpb24uIHRoZSBp
c3N1ZSBpcyBhbHNvIG5vdCBwcmVzZW50IGluIA0KPj4gMTAuNC0zLjQtMDA4Mnd3DQo+IFN0aWxs
IG15IHF1ZXN0aW9uIGlzIG5vdCBjbGVhcmVkLCAgZmlybXdhcmUgY3Jhc2ggaXMgZHVlIHRvIHRo
aXMgcGF0Y2ggPyBBbHNvIGxldCBtZSBrbm93IGRvIHlvdSBvYnNlcnZlZCBzYW1lIGJlaGF2aW9y
IHdpdGggYW55IG90aGVyIGNoaXBzZXQgPw0KDQpuby4gaXRzIHVucmVsYXRlZCB0byB0aGlzIHBh
dGNoIGJ1dCBzaW5jZSB5b3UncmUgd29ya2luZyBmb3IgcWNhIGkgdGhvdWdodCBpdCB3b3VsZCBt
YWtlIHNlbnNlIHRvIHRlbGwgeW91IHRoaXMgc2luY2Ugc2F3IHRoYXQgeW91J3JlIHVzaW5nIGF0
aDEwayBmaXJtd2FyZXMgd2hpY2ggYXJlbnQgcHVibGlzaGVkIG9mZmljaWFsbCBidXQgYmFzZWQg
b24gdGhlDQoNCnFjYSBmaXJtd2FyZXMgd2hpY2ggYXJlIHB1Ymxpc2hlZCBvbiBjaGlwY29kZS4g
c2luY2UgaSB3YXMgdGVzdGluZyB0aGVzZSBmaXJtd2FyZXMgdG9vIHNvbWUgd2Vla3MgYWdvIGkg
Zm91bmQgaXRzIGEgZ29vZCBpZGVhIHRvIHRlbGwgeW91IHRoaXMNCg0KPg0KPiAgIA0KPiBSZWdh
cmRzLA0KPiBCYWxhamkuDQo+DQo+PiBTZWJhc3RpYW4NCj4NCj4+PiBSZWdhcmRzLA0KPj4+IEJh
bGFqaS4NCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU2ViYXN0aWFuIEdv
dHRzY2hhbGwgW21haWx0bzpzLmdvdHRzY2hhbGxAZGQtd3J0LmNvbV0NCj4gU2VudDogV2VkbmVz
ZGF5LCBOb3ZlbWJlciAyOSwgMjAxNyAyOjA0IFBNDQo+IFRvOiBCYWxhamkgUG90aHVub29yaSA8
YnBvdGh1bm9AcXRpLnF1YWxjb21tLmNvbT47IGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnDQo+
IENjOiBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD
SF0gYXRoMTBrOiBoYW5kbGluZyBxb3MgYXQgU1RBIHNpZGUgYmFzZWQgb24gQVAgV01NIGVuYWJs
ZS9kaXNhYmxlDQo+DQo+IEFtIDI5LjExLjIwMTcgdW0gMDc6NTggc2NocmllYiBCYWxhamkgUG90
aHVub29yaToNCj4+IEhpIFNlYmFzdGlhbiwNCj4+DQo+PiBJZiBJIGFtIG5vdCB3cm9uZyB5b3Ug
YXJlIHNlZWluZyB0aGUgaXNzdWUgd2l0aCBXUlQzMjAwQUNNIChNYXJ2ZWxsIDg4Vzg5NjQpIGFz
IGNsaWVudCArIFFDQTk5ODQgKEZXIDogMTAuNC0zLjUuMy0wMDAzOCkgYXMgQVAgd2l0aCBiZWxv
dyBjaGFuZ2UgeW91IGFyZSBzZWVpbmcgdGhlIGNyYXNoIHdoaWxlIHJ1bm5pbmcgdHJhZmZpYyBi
ZXR3ZWVuIHRoZSBXUlQzMjAwQUNNICsgUUNBOTk4NCA/DQo+PiBEbyB5b3UgdXNlZCAgYW55IG90
aGVyIGNsaWVudCBpbiBwbGFjZSBvZiBXUlQzMjAwQUNNID8NCj4gdGhlcmUgaXMgbm90IG11Y2jC
oCB0cmFmZmljIHJlcXVpcmVkLiBhcyBpdCBzZWVtcyB0aGUgZmlybXdhcmUgY3Jhc2hlcyBpbW1l
ZGlhdGx5IGFmdGVyIGFzc29jaWF0aW9uLiB0aGUgaXNzdWUgaXMgYWxzbyBub3QgcHJlc2VudCBp
biAxMC40LTMuNC0wMDgyd3cNCj4NCj4+IENhbiB5b3Ugc2hhcmUgdGhlIG1vcmUgZGV0YWlscyBv
biBmaXJtd2FyZSBjcmFzaCA/DQo+IHNvIGEgZmlybXdhcmUgY3Jhc2hkdW1wIGZyb20gbG9nPyBp
J2xsIHRyeSB0byBnZXQgaXQgd2l0aGluIHRoZSBuZXh0IGhvdXJzLiBqdXN0IG5lZWQgdG8gcmVz
ZXR1cCB0aGUgdGVzdCBzY2VuYXJpbw0KPg0KPg0KPiBTZWJhc3RpYW4NCj4NCj4NCj4+IFJlZ2Fy
ZHMsDQo+PiBCYWxhamkuDQo+Pg0KPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+IEZy
b206IFNlYmFzdGlhbiBHb3R0c2NoYWxsIFttYWlsdG86cy5nb3R0c2NoYWxsQGRkLXdydC5jb21d
DQo+PiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDI5LCAyMDE3IDg6MjggQU0NCj4+IFRvOiBC
YWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9AcXRpLnF1YWxjb21tLmNvbT47IGF0aDEwa0BsaXN0
cy5pbmZyYWRlYWQub3JnDQo+PiBDYzogbGludXgtd2lyZWxlc3NAdmdlci5rZXJuZWwub3JnDQo+
PiBTdWJqZWN0OiBSZTogW1BBVENIXSBhdGgxMGs6IGhhbmRsaW5nIHFvcyBhdCBTVEEgc2lkZSBi
YXNlZCBvbiBBUCBXTU0gZW5hYmxlL2Rpc2FibGUNCj4+DQo+PiBkaWQgeW91IG5vdGljZcKgIHRo
YXQgTWFydmVsbCA4OFc4OTY0IGJhc2VkIGNsaWVudHMgd2lsbCBjcmFzaCAxMC40LTMuNS4zIGZp
cm13YXJlcz/CoCAodGVzdGVkIHdpdGggOTk4NCBhbmQgMTAuNC0zLjUuMy0wMDAzOCkgY2xpZW50
IGRldmljZSB3YXMgYSBsaW5rc3lzIHdydDMyMDBhY20gcnVubmluZyBkZC13cnQgZm9yIHRlc3Rp
bmcNCj4+DQo+PiBBbSAyOC4xMS4yMDE3IHVtIDExOjA3IHNjaHJpZWIgYnBvdGh1bm9AcXRpLnF1
YWxjb21tLmNvbToNCj4+PiBGcm9tOiBCYWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9AcXRpLnF1
YWxjb21tLmNvbT4NCj4+Pg0KPj4+IERhdGEgcGFja2V0cyBhcmUgbm90IHNlbnQgYnkgU1RBIGlu
IGNhc2Ugb2YgU1RBIGpvaW5lZCB0byBub24gUU9TIEFQDQo+Pj4gKFdNTSBkaXNhYmxlZCBBUCku
IFRoaXMgaXMgaGFwcGVuaW5nIGJlY2F1c2Ugb2YgU1RBIGlzIHNlbmRpbmcgZGF0YQ0KPj4+IHBh
Y2tldHMgdG8gZmlybXdhcmUgZnJvbSBob3N0IHdpdGggcW9zIGVuYWJsZWQgYWxvbmcgd2l0aCBu
b24gcW9zDQo+Pj4gcXVldWUgdmFsdWUoVElEID0gMTYpLg0KPj4+IER1ZSB0byBxb3MgZW5hYmxl
ZCwgZmlybXdhcmUgaXMgZGlzY2FyZGluZyB0aGUgcGFja2V0Lg0KPj4+DQo+Pj4gVGhpcyBwYXRj
aCBmaXhlcyB0aGlzIGlzc3VlIGJ5IHVwZGF0aW5nIHRoZSBxb3MgYmFzZWQgb24gc3RhdGlvbiBX
TUUNCj4+PiBjYXBhYmlsaXR5IGZpZWxkIGlmIFdNTSBpcyBkaXNhYmxlZCBpbiBBUC4NCj4+Pg0K
Pj4+IFRoaXMgcGF0Y2ggaXMgcmVxdWlyZWQgYnkgMTAuNCBmYW1pbHkgY2hpcHNldHMgbGlrZQ0K
Pj4+IFFDQTQwMTkvUUNBOTg4OC9RQ0E5ODg0L1FDQTk5WDAuDQo+Pj4gRmlybXdhcmUgVmVyc29p
biA6IDEwLjQtMy41LjEtMDAwMTguDQo+Pj4NCj4+PiBGb3IgMTAuMi40IGZhbWlseSBjaGlwc2V0
cyBRQ0E5ODhYL1FDQTk4ODcgYW5kIFFDQTYxNzQgdGhpcyBwYXRjaCBoYXMNCj4+PiBubyBlZmZl
Y3QuDQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBCYWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9A
cXRpLnF1YWxjb21tLmNvbT4NCj4+PiAtLS0NCj4+PiAgICAgZHJpdmVycy9uZXQvd2lyZWxlc3Mv
YXRoL2F0aDEway9tYWMuYyB8ICAgIDIgKy0NCj4+PiAgICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z
ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9u
ZXQvd2lyZWxlc3MvYXRoL2F0aDEway9tYWMuYw0KPj4+IGIvZHJpdmVycy9uZXQvd2lyZWxlc3Mv
YXRoL2F0aDEway9tYWMuYw0KPj4+IGluZGV4IDBhOTQ3ZWUuLjI2MTZiOTkgMTAwNjQ0DQo+Pj4g
LS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDEway9tYWMuYw0KPj4+ICsrKyBiL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMNCj4+PiBAQCAtMjU2Myw3ICsyNTYz
LDcgQEAgc3RhdGljIHZvaWQgYXRoMTBrX3BlZXJfYXNzb2NfaF9xb3Moc3RydWN0IGF0aDEwayAq
YXIsDQo+Pj4gICAgIAkJfQ0KPj4+ICAgICAJCWJyZWFrOw0KPj4+ICAgICAJY2FzZSBXTUlfVkRF
Vl9UWVBFX1NUQToNCj4+PiAtCQlpZiAodmlmLT5ic3NfY29uZi5xb3MpDQo+Pj4gKwkJaWYgKHN0
YS0+d21lKQ0KPj4+ICAgICAJCQlhcmctPnBlZXJfZmxhZ3MgfD0gYXJ2aWYtPmFyLT53bWkucGVl
cl9mbGFncy0+cW9zOw0KPj4+ICAgICAJCWJyZWFrOw0KPj4+ICAgICAJY2FzZSBXTUlfVkRFVl9U
WVBFX0lCU1M6DQo+PiAtLQ0KPj4gTWl0IGZyZXVuZGxpY2hlbiBHcsO8c3NlbiAvIFJlZ2FyZHMN
Cj4+DQo+PiBTZWJhc3RpYW4gR290dHNjaGFsbCAvIENUTw0KPj4NCj4+IE5ld01lZGlhLU5FVCBH
bWJIIC0gREQtV1JUDQo+PiBGaXJtZW5zaXR6OiAgU3R1YmVud2FsZGFsbGVlIDIxYSwgNjQ2MjUg
QmVuc2hlaW0NCj4+IFJlZ2lzdGVyZ2VyaWNodDogQW10c2dlcmljaHQgRGFybXN0YWR0LCBIUkIg
MjU0NzMNCj4+IEdlc2Now6RmdHNmw7xocmVyOiBQZXRlciBTdGVpbmjDpHVzZXIsIENocmlzdGlh
biBTY2hlZWxlIGh0dHA6Ly93d3cuZGQtd3J0LmNvbQ0KPj4gZW1haWw6IHMuZ290dHNjaGFsbEBk
ZC13cnQuY29tDQo+PiBUZWwuOiArNDk2MjUxLTU4MjY1MCAvIEZheDogKzQ5NjI1MS01ODI2NTY1
DQo+Pg0KDQotLSANCk1pdCBmcmV1bmRsaWNoZW4gR3LDvHNzZW4gLyBSZWdhcmRzDQoNClNlYmFz
dGlhbiBHb3R0c2NoYWxsIC8gQ1RPDQoNCk5ld01lZGlhLU5FVCBHbWJIIC0gREQtV1JUDQpGaXJt
ZW5zaXR6OiAgU3R1YmVud2FsZGFsbGVlIDIxYSwgNjQ2MjUgQmVuc2hlaW0NClJlZ2lzdGVyZ2Vy
aWNodDogQW10c2dlcmljaHQgRGFybXN0YWR0LCBIUkIgMjU0NzMNCkdlc2Now6RmdHNmw7xocmVy
OiBQZXRlciBTdGVpbmjDpHVzZXIsIENocmlzdGlhbiBTY2hlZWxlDQpodHRwOi8vd3d3LmRkLXdy
dC5jb20NCmVtYWlsOiBzLmdvdHRzY2hhbGxAZGQtd3J0LmNvbQ0KVGVsLjogKzQ5NjI1MS01ODI2
NTAgLyBGYXg6ICs0OTYyNTEtNTgyNjU2NQ0KDQo=

2017-11-29 02:57:34

by Sebastian Gottschall

[permalink] [raw]
Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

did you notice  that Marvell 88W8964 based clients will crash 10.4-3.5.3
firmwares?  (tested with 9984 and 10.4-3.5.3-00038)
client device was a linksys wrt3200acm running dd-wrt for testing

Am 28.11.2017 um 11:07 schrieb [email protected]:
> From: Balaji Pothunoori <[email protected]>
>
> Data packets are not sent by STA in case of STA joined to
> non QOS AP (WMM disabled AP). This is happening because of STA
> is sending data packets to firmware from host with qos enabled
> along with non qos queue value(TID = 16).
> Due to qos enabled, firmware is discarding the packet.
>
> This patch fixes this issue by updating the qos based on station
> WME capability field if WMM is disabled in AP.
>
> This patch is required by 10.4 family chipsets like
> QCA4019/QCA9888/QCA9884/QCA99X0.
> Firmware Versoin : 10.4-3.5.1-00018.
>
> For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch
> has no effect.
>
> Signed-off-by: Balaji Pothunoori <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 0a947ee..2616b99 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -2563,7 +2563,7 @@ static void ath10k_peer_assoc_h_qos(struct ath10k *ar,
> }
> break;
> case WMI_VDEV_TYPE_STA:
> - if (vif->bss_conf.qos)
> + if (sta->wme)
> arg->peer_flags |= arvif->ar->wmi.peer_flags->qos;
> break;
> case WMI_VDEV_TYPE_IBSS:


--
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565

2017-11-29 13:38:06

by Sebastian Gottschall

[permalink] [raw]
Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

Am 29.11.2017 um 11:12 schrieb Balaji Pothunoori:
>>> Hi Sebastian,
>>>
>>> If I am not wrong you are seeing the issue with WRT3200ACM (Marvell 88W8964) as client + QCA9984 (FW : 10.4-3.5.3-00038) as AP with below change you are seeing the crash while running traffic between the WRT3200ACM + QCA9984 ?
>>> Do you used any other client in place of WRT3200ACM ?
>> there is not much traffic required. as it seems the firmware crashes immediatly after association. the issue is also not present in 10.4-3.4-0082ww
> Still my question is not cleared, firmware crash is due to this patch ? Also let me know do you observed same behavior with any other chipset ?

no. its unrelated to this patch but since you're working for qca i
thought it would make sense to tell you this since saw that you're using
ath10k firmwares which arent published officiall but based on the

qca firmwares which are published on chipcode. since i was testing 
these firmwares too some weeks ago i found its a good idea to tell you this

>
>
> Regards,
> Balaji.
>
>> Sebastian
>
>>> Regards,
>>> Balaji.
> -----Original Message-----
> From: Sebastian Gottschall [mailto:[email protected]]
> Sent: Wednesday, November 29, 2017 2:04 PM
> To: Balaji Pothunoori <[email protected]>; [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable
>
> Am 29.11.2017 um 07:58 schrieb Balaji Pothunoori:
>> Hi Sebastian,
>>
>> If I am not wrong you are seeing the issue with WRT3200ACM (Marvell 88W8964) as client + QCA9984 (FW : 10.4-3.5.3-00038) as AP with below change you are seeing the crash while running traffic between the WRT3200ACM + QCA9984 ?
>> Do you used any other client in place of WRT3200ACM ?
> there is not much  traffic required. as it seems the firmware crashes immediatly after association. the issue is also not present in 10.4-3.4-0082ww
>
>> Can you share the more details on firmware crash ?
> so a firmware crashdump from log? i'll try to get it within the next hours. just need to resetup the test scenario
>
>
> Sebastian
>
>
>> Regards,
>> Balaji.
>>
>> -----Original Message-----
>> From: Sebastian Gottschall [mailto:[email protected]]
>> Sent: Wednesday, November 29, 2017 8:28 AM
>> To: Balaji Pothunoori <[email protected]>; [email protected]
>> Cc: [email protected]
>> Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable
>>
>> did you notice  that Marvell 88W8964 based clients will crash 10.4-3.5.3 firmwares?  (tested with 9984 and 10.4-3.5.3-00038) client device was a linksys wrt3200acm running dd-wrt for testing
>>
>> Am 28.11.2017 um 11:07 schrieb [email protected]:
>>> From: Balaji Pothunoori <[email protected]>
>>>
>>> Data packets are not sent by STA in case of STA joined to non QOS AP
>>> (WMM disabled AP). This is happening because of STA is sending data
>>> packets to firmware from host with qos enabled along with non qos
>>> queue value(TID = 16).
>>> Due to qos enabled, firmware is discarding the packet.
>>>
>>> This patch fixes this issue by updating the qos based on station WME
>>> capability field if WMM is disabled in AP.
>>>
>>> This patch is required by 10.4 family chipsets like
>>> QCA4019/QCA9888/QCA9884/QCA99X0.
>>> Firmware Versoin : 10.4-3.5.1-00018.
>>>
>>> For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch has
>>> no effect.
>>>
>>> Signed-off-by: Balaji Pothunoori <[email protected]>
>>> ---
>>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>>> b/drivers/net/wireless/ath/ath10k/mac.c
>>> index 0a947ee..2616b99 100644
>>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>>> @@ -2563,7 +2563,7 @@ static void ath10k_peer_assoc_h_qos(struct ath10k *ar,
>>> }
>>> break;
>>> case WMI_VDEV_TYPE_STA:
>>> - if (vif->bss_conf.qos)
>>> + if (sta->wme)
>>> arg->peer_flags |= arvif->ar->wmi.peer_flags->qos;
>>> break;
>>> case WMI_VDEV_TYPE_IBSS:
>> --
>> Mit freundlichen Grüssen / Regards
>>
>> Sebastian Gottschall / CTO
>>
>> NewMedia-NET GmbH - DD-WRT
>> Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
>> Registergericht: Amtsgericht Darmstadt, HRB 25473
>> Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com
>> email: [email protected]
>> Tel.: +496251-582650 / Fax: +496251-5826565
>>

--
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565

2017-11-29 08:33:41

by Sebastian Gottschall

[permalink] [raw]
Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

Am 29.11.2017 um 07:58 schrieb Balaji Pothunoori:
> Hi Sebastian,
>
> If I am not wrong you are seeing the issue with WRT3200ACM (Marvell 88W8964) as client + QCA9984 (FW : 10.4-3.5.3-00038) as AP with below change you are seeing the crash while running traffic between the WRT3200ACM + QCA9984 ?
> Do you used any other client in place of WRT3200ACM ?

there is not much  traffic required. as it seems the firmware crashes
immediatly after association. the issue is also not present in
10.4-3.4-0082ww

> Can you share the more details on firmware crash ?

so a firmware crashdump from log? i'll try to get it within the next
hours. just need to resetup the test scenario


Sebastian


>
> Regards,
> Balaji.
>
> -----Original Message-----
> From: Sebastian Gottschall [mailto:[email protected]]
> Sent: Wednesday, November 29, 2017 8:28 AM
> To: Balaji Pothunoori <[email protected]>; [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable
>
> did you notice  that Marvell 88W8964 based clients will crash 10.4-3.5.3 firmwares?  (tested with 9984 and 10.4-3.5.3-00038) client device was a linksys wrt3200acm running dd-wrt for testing
>
> Am 28.11.2017 um 11:07 schrieb [email protected]:
>> From: Balaji Pothunoori <[email protected]>
>>
>> Data packets are not sent by STA in case of STA joined to non QOS AP
>> (WMM disabled AP). This is happening because of STA is sending data
>> packets to firmware from host with qos enabled along with non qos
>> queue value(TID = 16).
>> Due to qos enabled, firmware is discarding the packet.
>>
>> This patch fixes this issue by updating the qos based on station WME
>> capability field if WMM is disabled in AP.
>>
>> This patch is required by 10.4 family chipsets like
>> QCA4019/QCA9888/QCA9884/QCA99X0.
>> Firmware Versoin : 10.4-3.5.1-00018.
>>
>> For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch has
>> no effect.
>>
>> Signed-off-by: Balaji Pothunoori <[email protected]>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index 0a947ee..2616b99 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -2563,7 +2563,7 @@ static void ath10k_peer_assoc_h_qos(struct ath10k *ar,
>> }
>> break;
>> case WMI_VDEV_TYPE_STA:
>> - if (vif->bss_conf.qos)
>> + if (sta->wme)
>> arg->peer_flags |= arvif->ar->wmi.peer_flags->qos;
>> break;
>> case WMI_VDEV_TYPE_IBSS:
>
> --
> Mit freundlichen Grüssen / Regards
>
> Sebastian Gottschall / CTO
>
> NewMedia-NET GmbH - DD-WRT
> Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
> Registergericht: Amtsgericht Darmstadt, HRB 25473
> Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com
> email: [email protected]
> Tel.: +496251-582650 / Fax: +496251-5826565
>

--
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565

2017-11-29 06:59:00

by Balaji Pothunoori

[permalink] [raw]
Subject: RE: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

SGkgU2ViYXN0aWFuLA0KDQpJZiBJIGFtIG5vdCB3cm9uZyB5b3UgYXJlIHNlZWluZyB0aGUgaXNz
dWUgd2l0aCBXUlQzMjAwQUNNIChNYXJ2ZWxsIDg4Vzg5NjQpIGFzIGNsaWVudCArIFFDQTk5ODQg
KEZXIDogMTAuNC0zLjUuMy0wMDAzOCkgYXMgQVAgd2l0aCBiZWxvdyBjaGFuZ2UgeW91IGFyZSBz
ZWVpbmcgdGhlIGNyYXNoIHdoaWxlIHJ1bm5pbmcgdHJhZmZpYyBiZXR3ZWVuIHRoZSBXUlQzMjAw
QUNNICsgUUNBOTk4NCA/DQpEbyB5b3UgdXNlZCAgYW55IG90aGVyIGNsaWVudCBpbiBwbGFjZSBv
ZiBXUlQzMjAwQUNNID8NCkNhbiB5b3Ugc2hhcmUgdGhlIG1vcmUgZGV0YWlscyBvbiBmaXJtd2Fy
ZSBjcmFzaCA/DQoNClJlZ2FyZHMsDQpCYWxhamkuDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQpGcm9tOiBTZWJhc3RpYW4gR290dHNjaGFsbCBbbWFpbHRvOnMuZ290dHNjaGFsbEBkZC13
cnQuY29tXSANClNlbnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgMjksIDIwMTcgODoyOCBBTQ0KVG86
IEJhbGFqaSBQb3RodW5vb3JpIDxicG90aHVub0BxdGkucXVhbGNvbW0uY29tPjsgYXRoMTBrQGxp
c3RzLmluZnJhZGVhZC5vcmcNCkNjOiBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmcNClN1
YmplY3Q6IFJlOiBbUEFUQ0hdIGF0aDEwazogaGFuZGxpbmcgcW9zIGF0IFNUQSBzaWRlIGJhc2Vk
IG9uIEFQIFdNTSBlbmFibGUvZGlzYWJsZQ0KDQpkaWQgeW91IG5vdGljZcKgIHRoYXQgTWFydmVs
bCA4OFc4OTY0IGJhc2VkIGNsaWVudHMgd2lsbCBjcmFzaCAxMC40LTMuNS4zIGZpcm13YXJlcz/C
oCAodGVzdGVkIHdpdGggOTk4NCBhbmQgMTAuNC0zLjUuMy0wMDAzOCkgY2xpZW50IGRldmljZSB3
YXMgYSBsaW5rc3lzIHdydDMyMDBhY20gcnVubmluZyBkZC13cnQgZm9yIHRlc3RpbmcNCg0KQW0g
MjguMTEuMjAxNyB1bSAxMTowNyBzY2hyaWViIGJwb3RodW5vQHF0aS5xdWFsY29tbS5jb206DQo+
IEZyb206IEJhbGFqaSBQb3RodW5vb3JpIDxicG90aHVub0BxdGkucXVhbGNvbW0uY29tPg0KPg0K
PiBEYXRhIHBhY2tldHMgYXJlIG5vdCBzZW50IGJ5IFNUQSBpbiBjYXNlIG9mIFNUQSBqb2luZWQg
dG8gbm9uIFFPUyBBUCANCj4gKFdNTSBkaXNhYmxlZCBBUCkuIFRoaXMgaXMgaGFwcGVuaW5nIGJl
Y2F1c2Ugb2YgU1RBIGlzIHNlbmRpbmcgZGF0YSANCj4gcGFja2V0cyB0byBmaXJtd2FyZSBmcm9t
IGhvc3Qgd2l0aCBxb3MgZW5hYmxlZCBhbG9uZyB3aXRoIG5vbiBxb3MgDQo+IHF1ZXVlIHZhbHVl
KFRJRCA9IDE2KS4NCj4gRHVlIHRvIHFvcyBlbmFibGVkLCBmaXJtd2FyZSBpcyBkaXNjYXJkaW5n
IHRoZSBwYWNrZXQuDQo+DQo+IFRoaXMgcGF0Y2ggZml4ZXMgdGhpcyBpc3N1ZSBieSB1cGRhdGlu
ZyB0aGUgcW9zIGJhc2VkIG9uIHN0YXRpb24gV01FIA0KPiBjYXBhYmlsaXR5IGZpZWxkIGlmIFdN
TSBpcyBkaXNhYmxlZCBpbiBBUC4NCj4NCj4gVGhpcyBwYXRjaCBpcyByZXF1aXJlZCBieSAxMC40
IGZhbWlseSBjaGlwc2V0cyBsaWtlIA0KPiBRQ0E0MDE5L1FDQTk4ODgvUUNBOTg4NC9RQ0E5OVgw
Lg0KPiBGaXJtd2FyZSBWZXJzb2luIDogMTAuNC0zLjUuMS0wMDAxOC4NCj4NCj4gRm9yIDEwLjIu
NCBmYW1pbHkgY2hpcHNldHMgUUNBOTg4WC9RQ0E5ODg3IGFuZCBRQ0E2MTc0IHRoaXMgcGF0Y2gg
aGFzIA0KPiBubyBlZmZlY3QuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEJhbGFqaSBQb3RodW5vb3Jp
IDxicG90aHVub0BxdGkucXVhbGNvbW0uY29tPg0KPiAtLS0NCj4gICBkcml2ZXJzL25ldC93aXJl
bGVzcy9hdGgvYXRoMTBrL21hYy5jIHwgICAgMiArLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGlu
c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQv
d2lyZWxlc3MvYXRoL2F0aDEway9tYWMuYyANCj4gYi9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgv
YXRoMTBrL21hYy5jDQo+IGluZGV4IDBhOTQ3ZWUuLjI2MTZiOTkgMTAwNjQ0DQo+IC0tLSBhL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsvbWFjLmMNCj4gKysrIGIvZHJpdmVycy9uZXQv
d2lyZWxlc3MvYXRoL2F0aDEway9tYWMuYw0KPiBAQCAtMjU2Myw3ICsyNTYzLDcgQEAgc3RhdGlj
IHZvaWQgYXRoMTBrX3BlZXJfYXNzb2NfaF9xb3Moc3RydWN0IGF0aDEwayAqYXIsDQo+ICAgCQl9
DQo+ICAgCQlicmVhazsNCj4gICAJY2FzZSBXTUlfVkRFVl9UWVBFX1NUQToNCj4gLQkJaWYgKHZp
Zi0+YnNzX2NvbmYucW9zKQ0KPiArCQlpZiAoc3RhLT53bWUpDQo+ICAgCQkJYXJnLT5wZWVyX2Zs
YWdzIHw9IGFydmlmLT5hci0+d21pLnBlZXJfZmxhZ3MtPnFvczsNCj4gICAJCWJyZWFrOw0KPiAg
IAljYXNlIFdNSV9WREVWX1RZUEVfSUJTUzoNCg0KDQotLQ0KTWl0IGZyZXVuZGxpY2hlbiBHcsO8
c3NlbiAvIFJlZ2FyZHMNCg0KU2ViYXN0aWFuIEdvdHRzY2hhbGwgLyBDVE8NCg0KTmV3TWVkaWEt
TkVUIEdtYkggLSBERC1XUlQNCkZpcm1lbnNpdHo6ICBTdHViZW53YWxkYWxsZWUgMjFhLCA2NDYy
NSBCZW5zaGVpbQ0KUmVnaXN0ZXJnZXJpY2h0OiBBbXRzZ2VyaWNodCBEYXJtc3RhZHQsIEhSQiAy
NTQ3Mw0KR2VzY2jDpGZ0c2bDvGhyZXI6IFBldGVyIFN0ZWluaMOkdXNlciwgQ2hyaXN0aWFuIFNj
aGVlbGUgaHR0cDovL3d3dy5kZC13cnQuY29tDQplbWFpbDogcy5nb3R0c2NoYWxsQGRkLXdydC5j
b20NClRlbC46ICs0OTYyNTEtNTgyNjUwIC8gRmF4OiArNDk2MjUxLTU4MjY1NjUNCg0K

2017-11-29 10:12:12

by Balaji Pothunoori

[permalink] [raw]
Subject: RE: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable

Pj4gSGkgU2ViYXN0aWFuLA0KPj4NCj4+IElmIEkgYW0gbm90IHdyb25nIHlvdSBhcmUgc2VlaW5n
IHRoZSBpc3N1ZSB3aXRoIFdSVDMyMDBBQ00gKE1hcnZlbGwgODhXODk2NCkgYXMgY2xpZW50ICsg
UUNBOTk4NCAoRlcgOiAxMC40LTMuNS4zLTAwMDM4KSBhcyBBUCB3aXRoIGJlbG93IGNoYW5nZSB5
b3UgYXJlIHNlZWluZyB0aGUgY3Jhc2ggd2hpbGUgcnVubmluZyB0cmFmZmljIGJldHdlZW4gdGhl
IFdSVDMyMDBBQ00gKyBRQ0E5OTg0ID8NCj4+IERvIHlvdSB1c2VkICBhbnkgb3RoZXIgY2xpZW50
IGluIHBsYWNlIG9mIFdSVDMyMDBBQ00gPw0KDQo+dGhlcmUgaXMgbm90IG11Y2ggIHRyYWZmaWMg
cmVxdWlyZWQuIGFzIGl0IHNlZW1zIHRoZSBmaXJtd2FyZSBjcmFzaGVzIGltbWVkaWF0bHkgYWZ0
ZXIgYXNzb2NpYXRpb24uIHRoZSBpc3N1ZSBpcyBhbHNvIG5vdCBwcmVzZW50IGluIDEwLjQtMy40
LTAwODJ3dw0KDQpTdGlsbCBteSBxdWVzdGlvbiBpcyBub3QgY2xlYXJlZCwgIGZpcm13YXJlIGNy
YXNoIGlzIGR1ZSB0byB0aGlzIHBhdGNoID8gQWxzbyBsZXQgbWUga25vdyBkbyB5b3Ugb2JzZXJ2
ZWQgc2FtZSBiZWhhdmlvciB3aXRoIGFueSBvdGhlciBjaGlwc2V0ID8NCg0KIA0KUmVnYXJkcywN
CkJhbGFqaS4NCg0KPlNlYmFzdGlhbg0KDQoNCj4+DQo+PiBSZWdhcmRzLA0KPj4gQmFsYWppLg0K
DQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogU2ViYXN0aWFuIEdvdHRzY2hhbGwg
W21haWx0bzpzLmdvdHRzY2hhbGxAZGQtd3J0LmNvbV0gDQpTZW50OiBXZWRuZXNkYXksIE5vdmVt
YmVyIDI5LCAyMDE3IDI6MDQgUE0NClRvOiBCYWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9AcXRp
LnF1YWxjb21tLmNvbT47IGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnDQpDYzogbGludXgtd2ly
ZWxlc3NAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBSZTogW1BBVENIXSBhdGgxMGs6IGhhbmRs
aW5nIHFvcyBhdCBTVEEgc2lkZSBiYXNlZCBvbiBBUCBXTU0gZW5hYmxlL2Rpc2FibGUNCg0KQW0g
MjkuMTEuMjAxNyB1bSAwNzo1OCBzY2hyaWViIEJhbGFqaSBQb3RodW5vb3JpOg0KPiBIaSBTZWJh
c3RpYW4sDQo+DQo+IElmIEkgYW0gbm90IHdyb25nIHlvdSBhcmUgc2VlaW5nIHRoZSBpc3N1ZSB3
aXRoIFdSVDMyMDBBQ00gKE1hcnZlbGwgODhXODk2NCkgYXMgY2xpZW50ICsgUUNBOTk4NCAoRlcg
OiAxMC40LTMuNS4zLTAwMDM4KSBhcyBBUCB3aXRoIGJlbG93IGNoYW5nZSB5b3UgYXJlIHNlZWlu
ZyB0aGUgY3Jhc2ggd2hpbGUgcnVubmluZyB0cmFmZmljIGJldHdlZW4gdGhlIFdSVDMyMDBBQ00g
KyBRQ0E5OTg0ID8NCj4gRG8geW91IHVzZWQgIGFueSBvdGhlciBjbGllbnQgaW4gcGxhY2Ugb2Yg
V1JUMzIwMEFDTSA/DQoNCnRoZXJlIGlzIG5vdCBtdWNowqAgdHJhZmZpYyByZXF1aXJlZC4gYXMg
aXQgc2VlbXMgdGhlIGZpcm13YXJlIGNyYXNoZXMgaW1tZWRpYXRseSBhZnRlciBhc3NvY2lhdGlv
bi4gdGhlIGlzc3VlIGlzIGFsc28gbm90IHByZXNlbnQgaW4gMTAuNC0zLjQtMDA4Mnd3DQoNCj4g
Q2FuIHlvdSBzaGFyZSB0aGUgbW9yZSBkZXRhaWxzIG9uIGZpcm13YXJlIGNyYXNoID8NCg0Kc28g
YSBmaXJtd2FyZSBjcmFzaGR1bXAgZnJvbSBsb2c/IGknbGwgdHJ5IHRvIGdldCBpdCB3aXRoaW4g
dGhlIG5leHQgaG91cnMuIGp1c3QgbmVlZCB0byByZXNldHVwIHRoZSB0ZXN0IHNjZW5hcmlvDQoN
Cg0KU2ViYXN0aWFuDQoNCg0KPg0KPiBSZWdhcmRzLA0KPiBCYWxhamkuDQo+DQo+IC0tLS0tT3Jp
Z2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFNlYmFzdGlhbiBHb3R0c2NoYWxsIFttYWlsdG86
cy5nb3R0c2NoYWxsQGRkLXdydC5jb21dDQo+IFNlbnQ6IFdlZG5lc2RheSwgTm92ZW1iZXIgMjks
IDIwMTcgODoyOCBBTQ0KPiBUbzogQmFsYWppIFBvdGh1bm9vcmkgPGJwb3RodW5vQHF0aS5xdWFs
Y29tbS5jb20+OyBhdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBDYzogbGludXgtd2lyZWxl
c3NAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGF0aDEwazogaGFuZGxp
bmcgcW9zIGF0IFNUQSBzaWRlIGJhc2VkIG9uIEFQIFdNTSBlbmFibGUvZGlzYWJsZQ0KPg0KPiBk
aWQgeW91IG5vdGljZcKgIHRoYXQgTWFydmVsbCA4OFc4OTY0IGJhc2VkIGNsaWVudHMgd2lsbCBj
cmFzaCAxMC40LTMuNS4zIGZpcm13YXJlcz/CoCAodGVzdGVkIHdpdGggOTk4NCBhbmQgMTAuNC0z
LjUuMy0wMDAzOCkgY2xpZW50IGRldmljZSB3YXMgYSBsaW5rc3lzIHdydDMyMDBhY20gcnVubmlu
ZyBkZC13cnQgZm9yIHRlc3RpbmcNCj4NCj4gQW0gMjguMTEuMjAxNyB1bSAxMTowNyBzY2hyaWVi
IGJwb3RodW5vQHF0aS5xdWFsY29tbS5jb206DQo+PiBGcm9tOiBCYWxhamkgUG90aHVub29yaSA8
YnBvdGh1bm9AcXRpLnF1YWxjb21tLmNvbT4NCj4+DQo+PiBEYXRhIHBhY2tldHMgYXJlIG5vdCBz
ZW50IGJ5IFNUQSBpbiBjYXNlIG9mIFNUQSBqb2luZWQgdG8gbm9uIFFPUyBBUA0KPj4gKFdNTSBk
aXNhYmxlZCBBUCkuIFRoaXMgaXMgaGFwcGVuaW5nIGJlY2F1c2Ugb2YgU1RBIGlzIHNlbmRpbmcg
ZGF0YQ0KPj4gcGFja2V0cyB0byBmaXJtd2FyZSBmcm9tIGhvc3Qgd2l0aCBxb3MgZW5hYmxlZCBh
bG9uZyB3aXRoIG5vbiBxb3MNCj4+IHF1ZXVlIHZhbHVlKFRJRCA9IDE2KS4NCj4+IER1ZSB0byBx
b3MgZW5hYmxlZCwgZmlybXdhcmUgaXMgZGlzY2FyZGluZyB0aGUgcGFja2V0Lg0KPj4NCj4+IFRo
aXMgcGF0Y2ggZml4ZXMgdGhpcyBpc3N1ZSBieSB1cGRhdGluZyB0aGUgcW9zIGJhc2VkIG9uIHN0
YXRpb24gV01FDQo+PiBjYXBhYmlsaXR5IGZpZWxkIGlmIFdNTSBpcyBkaXNhYmxlZCBpbiBBUC4N
Cj4+DQo+PiBUaGlzIHBhdGNoIGlzIHJlcXVpcmVkIGJ5IDEwLjQgZmFtaWx5IGNoaXBzZXRzIGxp
a2UNCj4+IFFDQTQwMTkvUUNBOTg4OC9RQ0E5ODg0L1FDQTk5WDAuDQo+PiBGaXJtd2FyZSBWZXJz
b2luIDogMTAuNC0zLjUuMS0wMDAxOC4NCj4+DQo+PiBGb3IgMTAuMi40IGZhbWlseSBjaGlwc2V0
cyBRQ0E5ODhYL1FDQTk4ODcgYW5kIFFDQTYxNzQgdGhpcyBwYXRjaCBoYXMNCj4+IG5vIGVmZmVj
dC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBCYWxhamkgUG90aHVub29yaSA8YnBvdGh1bm9AcXRp
LnF1YWxjb21tLmNvbT4NCj4+IC0tLQ0KPj4gICAgZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0
aDEway9tYWMuYyB8ICAgIDIgKy0NCj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr
KSwgMSBkZWxldGlvbigtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVz
cy9hdGgvYXRoMTBrL21hYy5jDQo+PiBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9hdGgxMGsv
bWFjLmMNCj4+IGluZGV4IDBhOTQ3ZWUuLjI2MTZiOTkgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJz
L25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL21hYy5jDQo+PiArKysgYi9kcml2ZXJzL25ldC93aXJl
bGVzcy9hdGgvYXRoMTBrL21hYy5jDQo+PiBAQCAtMjU2Myw3ICsyNTYzLDcgQEAgc3RhdGljIHZv
aWQgYXRoMTBrX3BlZXJfYXNzb2NfaF9xb3Moc3RydWN0IGF0aDEwayAqYXIsDQo+PiAgICAJCX0N
Cj4+ICAgIAkJYnJlYWs7DQo+PiAgICAJY2FzZSBXTUlfVkRFVl9UWVBFX1NUQToNCj4+IC0JCWlm
ICh2aWYtPmJzc19jb25mLnFvcykNCj4+ICsJCWlmIChzdGEtPndtZSkNCj4+ICAgIAkJCWFyZy0+
cGVlcl9mbGFncyB8PSBhcnZpZi0+YXItPndtaS5wZWVyX2ZsYWdzLT5xb3M7DQo+PiAgICAJCWJy
ZWFrOw0KPj4gICAgCWNhc2UgV01JX1ZERVZfVFlQRV9JQlNTOg0KPg0KPiAtLQ0KPiBNaXQgZnJl
dW5kbGljaGVuIEdyw7xzc2VuIC8gUmVnYXJkcw0KPg0KPiBTZWJhc3RpYW4gR290dHNjaGFsbCAv
IENUTw0KPg0KPiBOZXdNZWRpYS1ORVQgR21iSCAtIERELVdSVA0KPiBGaXJtZW5zaXR6OiAgU3R1
YmVud2FsZGFsbGVlIDIxYSwgNjQ2MjUgQmVuc2hlaW0NCj4gUmVnaXN0ZXJnZXJpY2h0OiBBbXRz
Z2VyaWNodCBEYXJtc3RhZHQsIEhSQiAyNTQ3Mw0KPiBHZXNjaMOkZnRzZsO8aHJlcjogUGV0ZXIg
U3RlaW5ow6R1c2VyLCBDaHJpc3RpYW4gU2NoZWVsZSBodHRwOi8vd3d3LmRkLXdydC5jb20NCj4g
ZW1haWw6IHMuZ290dHNjaGFsbEBkZC13cnQuY29tDQo+IFRlbC46ICs0OTYyNTEtNTgyNjUwIC8g
RmF4OiArNDk2MjUxLTU4MjY1NjUNCj4NCg0KLS0gDQpNaXQgZnJldW5kbGljaGVuIEdyw7xzc2Vu
IC8gUmVnYXJkcw0KDQpTZWJhc3RpYW4gR290dHNjaGFsbCAvIENUTw0KDQpOZXdNZWRpYS1ORVQg
R21iSCAtIERELVdSVA0KRmlybWVuc2l0ejogIFN0dWJlbndhbGRhbGxlZSAyMWEsIDY0NjI1IEJl
bnNoZWltDQpSZWdpc3RlcmdlcmljaHQ6IEFtdHNnZXJpY2h0IERhcm1zdGFkdCwgSFJCIDI1NDcz
DQpHZXNjaMOkZnRzZsO8aHJlcjogUGV0ZXIgU3RlaW5ow6R1c2VyLCBDaHJpc3RpYW4gU2NoZWVs
ZQ0KaHR0cDovL3d3dy5kZC13cnQuY29tDQplbWFpbDogcy5nb3R0c2NoYWxsQGRkLXdydC5jb20N
ClRlbC46ICs0OTYyNTEtNTgyNjUwIC8gRmF4OiArNDk2MjUxLTU4MjY1NjUNCg0K

2017-12-14 15:19:54

by Kalle Valo

[permalink] [raw]
Subject: Re: ath10k: handling qos at STA side based on AP WMM enable/disable

[email protected] wrote:

> Data packets are not sent by STA in case of STA joined to
> non QOS AP (WMM disabled AP). This is happening because of STA
> is sending data packets to firmware from host with qos enabled
> along with non qos queue value(TID = 16).
> Due to qos enabled, firmware is discarding the packet.
>
> This patch fixes this issue by updating the qos based on station
> WME capability field if WMM is disabled in AP.
>
> This patch is required by 10.4 family chipsets like
> QCA4019/QCA9888/QCA9884/QCA99X0.
> Firmware Versoin : 10.4-3.5.1-00018.
>
> For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch
> has no effect.
>
> Signed-off-by: Balaji Pothunoori <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

07ffb4497360 ath10k: handling qos at STA side based on AP WMM enable/disable

--
https://patchwork.kernel.org/patch/10079089/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches