2024-03-31 18:33:03

by Karthikeyan Kathirvel

Subject: [PATCH 2/2] wifi: ath12k: match WMI BSS chan info structure with firmware definition

From: P Praneesh <[email protected]>

struct wmi_pdev_bss_chan_info_event is not similar to the firmware
struct definition, this will cause some random failures.

Fix by matching the struct wmi_pdev_bss_chan_info_event with the
firmware structure definition.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")

Signed-off-by: P Praneesh <[email protected]>
Signed-off-by: Karthikeyan Kathirvel <[email protected]>
---
drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index f67e355ee202..96e8fb164bd4 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -4021,7 +4021,6 @@ struct wmi_vdev_stopped_event {
} __packed;

struct wmi_pdev_bss_chan_info_event {
- __le32 pdev_id;
__le32 freq; /* Units in MHz */
__le32 noise_floor; /* units are dBm */
/* rx clear - how often the channel was unused */
@@ -4039,6 +4038,7 @@ struct wmi_pdev_bss_chan_info_event {
/*rx_cycle cnt for my bss in 64bits format */
__le32 rx_bss_cycle_count_low;
__le32 rx_bss_cycle_count_high;
+ __le32 pdev_id;
} __packed;

#define WMI_VDEV_INSTALL_KEY_COMPL_STATUS_SUCCESS 0
--
2.34.1

2024-04-01 15:01:26

by Jeff Johnson

Subject: Re: [PATCH 2/2] wifi: ath12k: match WMI BSS chan info structure with firmware definition

On 3/31/2024 11:32 AM, Karthikeyan Kathirvel wrote:
> From: P Praneesh <[email protected]>
>
> struct wmi_pdev_bss_chan_info_event is not similar to the firmware
> struct definition, this will cause some random failures.
>
> Fix by matching the struct wmi_pdev_bss_chan_info_event with the
> firmware structure definition.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>

remove this blank line

> Signed-off-by: P Praneesh <[email protected]>
> Signed-off-by: Karthikeyan Kathirvel <[email protected]>

2024-04-01 16:12:08

by Jeff Johnson

Subject: Re: [PATCH 2/2] wifi: ath12k: match WMI BSS chan info structure with firmware definition

On 4/1/2024 8:01 AM, Jeff Johnson wrote:
> On 3/31/2024 11:32 AM, Karthikeyan Kathirvel wrote:
>> From: P Praneesh <[email protected]>
>>
>> struct wmi_pdev_bss_chan_info_event is not similar to the firmware
>> struct definition, this will cause some random failures.
>>
>> Fix by matching the struct wmi_pdev_bss_chan_info_event with the
>> firmware structure definition.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>
>> Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>>
>
> remove this blank line
>
>> Signed-off-by: P Praneesh <[email protected]>
>> Signed-off-by: Karthikeyan Kathirvel <[email protected]>
>
>
Kalle can fix this when he merges into pending

Acked-by: Jeff Johnson <[email protected]>