I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Baole Ni <[email protected]>
---
drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index a920d70..477f2b2 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -22,7 +22,7 @@
#include "wcn36xx.h"
unsigned int wcn36xx_dbg_mask;
-module_param_named(debug_mask, wcn36xx_dbg_mask, uint, 0644);
+module_param_named(debug_mask, wcn36xx_dbg_mask, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(debug_mask, "Debugging mask");
#define CHAN2G(_freq, _idx) { \
--
2.9.2
(Trimming CC)
Baole Ni <[email protected]> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <[email protected]>
> Signed-off-by: Baole Ni <[email protected]>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Over 1000 patches? It's totally inapproriate to spam people's inboxes
(including mine) like this. PLEASE first study how kernel development
works and then start with something small, not like this.
I'm dropping all patches from this patchset.
--
Kalle Valo
On 02-08-16 19:52, Kalle Valo wrote:
> (Trimming CC)
>
> Baole Ni <[email protected]> writes:
>
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
>>
>> Signed-off-by: Chuansheng Liu <[email protected]>
>> Signed-off-by: Baole Ni <[email protected]>
>> ---
>> drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Over 1000 patches? It's totally inapproriate to spam people's inboxes
> (including mine) like this. PLEASE first study how kernel development
> works and then start with something small, not like this.
>
> I'm dropping all patches from this patchset.
And this type of change has been tried before and burned by Linus as
everybody with a bit of *nix background knows the meaning of the
numerical access permissions.
Regards,
Arend