2008-09-25 17:45:03

by Rami Rosen

[permalink] [raw]
Subject: [PATCH] mac80211: remove wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h

Hi,
This patch removes wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h
as they are not used. (These variable names in fact a double declaration; one
is a pointer to dentry struct (for DEBUGFS) and the second is an
array of ints
(for Extra statistics for TX/RX debugging - when setting
CONFIG_MAC80211_DEBUG_COUNTERS); both are not used.


Regards,
Rami Rosen

Signed-off-by: Rami Rosen <[email protected]>


Attachments:
(No filename) (428.00 B)
patch.txt (1.62 kB)
Download all attachments

2008-09-26 11:56:06

by Rami Rosen

[permalink] [raw]
Subject: Re: [PATCH] [RESEND] mac80211: remove wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h

Hi,

This patch removes wme_tx_queue and wme_rx_queue from struct sta_info
and from the debugfs sub-structure of struct sta_info
in net/mac80211/sta_info.h, as they are useless and not used.


Regards,
Rami Rosen

Signed-off-by: Rami Rosen <[email protected]>


On Fri, Sep 26, 2008 at 2:06 PM, Johannes Berg
<[email protected]> wrote:
> On Thu, 2008-09-25 at 20:45 +0300, Rami Rosen wrote:
>> Hi,
>> This patch removes wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h
>> as they are not used. (These variable names in fact a double declaration; one
>> is a pointer to dentry struct (for DEBUGFS) and the second is an
>> array of ints
>> (for Extra statistics for TX/RX debugging - when setting
>> CONFIG_MAC80211_DEBUG_COUNTERS); both are not used.
>
> Not really a double declaration since one of them is in the debugfs
> sub-structure, but yeah, useless.
>
>>
>>
>> Regards,
>> Rami Rosen
>>
>> Signed-off-by: Rami Rosen <[email protected]>
>
> Acked-by: Johannes Berg <[email protected]>
>
> but you may need to resend with a patch description appropriate for the
> changelog, I'll let John sort that out I guess.
>
> johannes
>


Attachments:
(No filename) (1.14 kB)
patch.txt (1.62 kB)
Download all attachments

2008-09-26 11:06:14

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] mac80211: remove wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h

On Thu, 2008-09-25 at 20:45 +0300, Rami Rosen wrote:
> Hi,
> This patch removes wme_tx_queue and wme_rx_queue from net/mac80211/sta_info.h
> as they are not used. (These variable names in fact a double declaration; one
> is a pointer to dentry struct (for DEBUGFS) and the second is an
> array of ints
> (for Extra statistics for TX/RX debugging - when setting
> CONFIG_MAC80211_DEBUG_COUNTERS); both are not used.

Not really a double declaration since one of them is in the debugfs
sub-structure, but yeah, useless.

>
>
> Regards,
> Rami Rosen
>
> Signed-off-by: Rami Rosen <[email protected]>

Acked-by: Johannes Berg <[email protected]>

but you may need to resend with a patch description appropriate for the
changelog, I'll let John sort that out I guess.

johannes


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part