Hi,
- This patch (against the linux-wireless-next git tree) removes a
redundant check in ieee80211_master_start_xmit (net/mac80211/tx.c).
In this method, there is no need to call again the
ieee80211_is_data() method; this is checked immediately before, in the
"if" command (we will not enter this block unless ieee80211_is_data()
is true, so that the "and" (&&) condition in that "if" command will be
fullfilled ).
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[email protected]>
Hi,
- This patch (against the linux-wireless-next git tree) removes a
redundant check in ieee80211_master_start_xmit (net/mac80211/tx.c)
and adjust indentation in this method accordingly.
In this method, there is no need to call again the
ieee80211_is_data() method; this is checked immediately before, in the
"if" command (we will not enter this block unless ieee80211_is_data()
is true, so that the "and" (&&) condition in that "if" command will be
fullfilled ).
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[email protected]>
On Thu, Oct 2, 2008 at 4:27 PM, Johannes Berg <[email protected]> wrote:
> On Thu, 2008-10-02 at 15:56 +0300, Rami Rosen wrote:
>> Hi,
>>
>> - This patch (against the linux-wireless-next git tree) removes a
>> redundant check in ieee80211_master_start_xmit (net/mac80211/tx.c).
>>
>> In this method, there is no need to call again the
>> ieee80211_is_data() method; this is checked immediately before, in the
>> "if" command (we will not enter this block unless ieee80211_is_data()
>> is true, so that the "and" (&&) condition in that "if" command will be
>> fullfilled ).
>
> You should un-indent the code accordingly.
>
> johannes
>
On Thu, 2008-10-02 at 16:48 +0300, Rami Rosen wrote:
> Hi,
>
> - This patch (against the linux-wireless-next git tree) removes a
> redundant check in ieee80211_master_start_xmit (net/mac80211/tx.c)
> and adjust indentation in this method accordingly.
>
> In this method, there is no need to call again the
> ieee80211_is_data() method; this is checked immediately before, in the
> "if" command (we will not enter this block unless ieee80211_is_data()
> is true, so that the "and" (&&) condition in that "if" command will be
> fullfilled ).
Looks good to me, but I think you should look a bit more into how to
format a proper patch and try to send it inline rather than as an
attachment. Have you seen http://linux.yyz.us/patch-format.html? The
main point I guess is that we don't want to have the "Hi," and
"Regards, ..." stuff in the kernel changelog.
Acked-by: Johannes Berg <[email protected]>
johannes
On Thu, 2008-10-02 at 15:56 +0300, Rami Rosen wrote:
> Hi,
>
> - This patch (against the linux-wireless-next git tree) removes a
> redundant check in ieee80211_master_start_xmit (net/mac80211/tx.c).
>
> In this method, there is no need to call again the
> ieee80211_is_data() method; this is checked immediately before, in the
> "if" command (we will not enter this block unless ieee80211_is_data()
> is true, so that the "and" (&&) condition in that "if" command will be
> fullfilled ).
You should un-indent the code accordingly.
johannes