2009-01-06 08:50:34

by Rami Rosen

Subject: [PATCH 1/6] mac80211: remove an unnecessary assignment to info in __ieee80211_tx().

This patch removes an unnecessary assignment to info
in __ieee80211_tx() , tx.c.

(wireless-testing).

Signed-off-by: Rami Rosen <[email protected]>

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index c723dcc..2627da8 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1055,7 +1055,6 @@ static int __ieee80211_tx(struct ieee80211_local
*local, struct sk_buff *skb,
if (skb) {
if (netif_subqueue_stopped(local->mdev, skb))
return IEEE80211_TX_AGAIN;
- info = IEEE80211_SKB_CB(skb);

ret = local->ops->tx(local_to_hw(local), skb);
if (ret)

2009-01-07 21:00:39

by John W. Linville

Subject: Re: [PATCH 1/6] mac80211: remove an unnecessary assignment to info in __ieee80211_tx().

On Tue, Jan 06, 2009 at 10:50:33AM +0200, Rami Rosen wrote:
> This patch removes an unnecessary assignment to info
> in __ieee80211_tx() , tx.c.
>
> (wireless-testing).
>
> Signed-off-by: Rami Rosen <[email protected]>

BTW, would you mind not putting "(wireless-testing)" or similar stuff
in the changelog? It can be handy to know, but you should put it
after the Signed-off-by and after a line starting with "---":

This patch removes an unnecessary assignment to info
in __ieee80211_tx() , tx.c.

Signed-off-by: Rami Rosen <[email protected]>
---
(wireless-testing).

Thanks!

John
--
John W. Linville Linux should be at the core
[email protected] of your literate lifestyle.