2009-01-06 08:50:52

by Rami Rosen

Subject: [PATCH 2/6] mac80211: remove an unused parameter in ieee80211_rx_mgmt_probe_req().

This patch removes an unused parameter (rx_status) in
ieee80211_rx_mgmt_probe_req(),
in mlme.c.

(wireless-testing).

Signed-off-by: Rami Rosen <[email protected]>

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index e317c6d..439c301 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -1848,8 +1848,7 @@ static void ieee80211_rx_mgmt_beacon(struct
ieee80211_sub_if_data *sdata,
static void ieee80211_rx_mgmt_probe_req(struct ieee80211_sub_if_data *sdata,
struct ieee80211_if_sta *ifsta,
struct ieee80211_mgmt *mgmt,
- size_t len,
- struct ieee80211_rx_status *rx_status)
+ size_t len)
{
struct ieee80211_local *local = sdata->local;
int tx_last_beacon;
@@ -1969,8 +1968,7 @@ static void ieee80211_sta_rx_queued_mgmt(struct
ieee80211_sub_if_data *sdata,

switch (fc & IEEE80211_FCTL_STYPE) {
case IEEE80211_STYPE_PROBE_REQ:
- ieee80211_rx_mgmt_probe_req(sdata, ifsta, mgmt, skb->len,
- rx_status);
+ ieee80211_rx_mgmt_probe_req(sdata, ifsta, mgmt, skb->len);
break;
case IEEE80211_STYPE_PROBE_RESP:
ieee80211_rx_mgmt_probe_resp(sdata, mgmt, skb->len, rx_status);

2009-01-08 09:17:04

by Jouni Malinen

Subject: Re: [PATCH 2/6] mac80211: remove an unused parameter in ieee80211_rx_mgmt_probe_req().

On Tue, Jan 06, 2009 at 10:50:51AM +0200, Rami Rosen wrote:
> This patch removes an unused parameter (rx_status) in
> ieee80211_rx_mgmt_probe_req(),
> in mlme.c.

I could think of some uses for this information in deciding what to
include in (or more likely, which TX parameters to use for) Probe
Response, but this parameter can be easily added back should someone
ever end up implementing this, so I'm not against removing it now.

--
Jouni Malinen PGP id EFC895FA