2009-05-24 17:43:50

by Rami Rosen

Subject: [PATCH] iwlwifi: avoid build warning in iwl-core.

When building when CONFIG_IWLWIFI_DEBUG is not set is not set, we get
the following
warning:
/work/src/w/drivers/net/wireless/iwlwifi/iwl-core.c: In function ?iwl_isr?:
/work/src/w/drivers/net/wireless/iwlwifi/iwl-core.c:1707: warning:
unused variable ?inta_fh?

This patch avoids this warning by adding #ifdef CONFIG_IWLWIFI_DEBUG
before the declaration of inta_fh in iwl_isr() in
drivers/net/wireless/iwlwifi/iwl-core.c

Signed-off-by: Rami Rosen <[email protected]>

---
(wireless-testing).

diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c
b/drivers/net/wireless/iwlwifi/iwl-core.c
index e93ddb7..811a525 100644
--- a/drivers/net/wireless/iwlwifi/iwl-core.c
+++ b/drivers/net/wireless/iwlwifi/iwl-core.c
@@ -1704,8 +1704,9 @@ static irqreturn_t iwl_isr(int irq, void *data)
{
struct iwl_priv *priv = data;
u32 inta, inta_mask;
+#ifdef CONFIG_IWLWIFI_DEBUG
u32 inta_fh;
-
+#endif
if (!priv)
return IRQ_NONE;

2009-05-26 16:54:05

by Reinette Chatre

Subject: Re: [PATCH] iwlwifi: avoid build warning in iwl-core.

On Sun, 2009-05-24 at 10:43 -0700, Rami Rosen wrote:
> When building when CONFIG_IWLWIFI_DEBUG is not set is not set, we get
> the following
> warning:
> /work/src/w/drivers/net/wireless/iwlwifi/iwl-core.c: In function ‘iwl_isr’:
> /work/src/w/drivers/net/wireless/iwlwifi/iwl-core.c:1707: warning:
> unused variable ‘inta_fh’
>
> This patch avoids this warning by adding #ifdef CONFIG_IWLWIFI_DEBUG
> before the declaration of inta_fh in iwl_isr() in
> drivers/net/wireless/iwlwifi/iwl-core.c
>
> Signed-off-by: Rami Rosen <[email protected]>
>
> ---

There is just a double "is not set" in the commit message.

Thank you

Acked-by: Reinette Chatre <[email protected]>

Reinette